Closed Bug 2089379 Opened 13 days ago Closed 4 days ago

[wpt-sync] Sync PR 64416 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=306860

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox162 fixed)

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64416 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64416
Details from upstream follow.

Yoav Weiss <yoav.weiss@shopify.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=306860

WebKit export from bug: Speculation Rules don'<!---->t trigger for non-<!---->visible anchors with visible descendants

<pre>
Speculation Rules: ensure that non-visible anchors with visible descendants get prefetched

Anchor elements with display: contents may not be visible but could have visible descendants.
The current speculation rules logic doesn't account for that, and prevents prefetches on such elements from working.
This fixes that by looking at their descendants and seeing if they are rendered.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=306860">https://bugs.webkit.org/show_bug.cgi?id=306860</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/306730@main">https://commits.webkit.org/306730@main</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 216 tests and 1 subtests

Status Summary

Firefox

OK : 211[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 212[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-windows11-32-25h2-opt] 213[Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 214[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
PASS : 176[Gecko-linux2404-64-debug] 177[Gecko-linux2404-64-opt] 178[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-windows11-32-25h2-opt] 179[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL : 4[GitHub] 73[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 74[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug]
TIMEOUT: 1
ERROR : 1
NOTRUN : 1

Chrome

PASS : 4
TIMEOUT: 1
ERROR : 1
NOTRUN : 1

Safari

PASS : 4
TIMEOUT: 2
NOTRUN : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /speculation-rules/prefetch/document-rules-visibility.https.html [wpt.fyi]
    • test that link with display:contents and text content is prefetched: FAIL
    • test that link with display:contents and visible child element is prefetched: FAIL
    • test that customized built-in anchor element with shadow DOM is prefetched: FAIL
    • test that slotted anchor inside custom element is prefetched: FAIL

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.