[wpt-sync] Sync PR 64421 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=328228
Categories
(Core :: SVG, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 64421 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/64421
Details from upstream follow.
Sam Weinig <sam@webkit.org> wrote:
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=328228
WebKit export from bug: [<!---->Image Redux]<!----> Place and draw an \<<!---->feImage><!---->'<!---->s image like an SVG \<<!---->image><!---->
<pre>
[Image Redux] Place and draw an <feImage>'s image like an SVG <image>The filter effects states:
"If the href references a stand-alone image resource such as a JPEG, PNG or SVG file, then the image resource is
rendered according to the behavior of the image element"
- <a href="https://drafts.csswg.org/filter-effects/#feImageElement.">https://drafts.csswg.org/filter-effects/#feImageElement.</a>Luckily for us, we have been refactoring all the code to size SVG images, but unluckily for us, it requires having
a real RenderObject to work. So, RenderSVGResourceFEImage and LegacyRenderSVGResourceFEImage are born, and like the
other image render objects, each hold a RenderImageResource with a Style::Image in it.With these additional image renderers, it made sense to further factor out some logic from RenderSVGImage and
LegacyRenderSVGImage to calculate the drawing options via calculateSVGImageDrawingOptions().An <feImage> with nothing to show, such as one without a renderer in a display: none subtree, now produces transparent
black rather than failing the whole filter, matching Firefox. The spec does not specify what do with the display: none,
but this seems like a good default choice.Also, the subregion, filter region, and scale are now needed when an effect is created, so they get passed from SVGFilterRenderer
in a new FilterEffectPlacement struct.A few test results show an "image-size" attribute no longer being present on an feImage. This is due to how the legacy
SVG renderer's dumping work for filters, where it gives it a zero sized dummy region. Now that we are correctly sizing
the images, the dummy region causes use to make the images zero size. This is only an artifact of dumping, as all the
tests that actual invoke the filters have a non-zero sized region.WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=328228">https://bugs.webkit.org/show_bug.cgi?id=328228</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/324592@main">https://commits.webkit.org/324592@main</a>
</pre>
| Assignee | ||
Updated•14 days ago
|
| Assignee | ||
Updated•10 days ago
|
| Assignee | ||
Updated•10 days ago
|
| Assignee | ||
Comment 1•10 days ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=116537
| Assignee | ||
Comment 2•10 days ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 426 tests
Status Summary
Firefox
OK : 38
PASS : 4[GitHub] 23[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 3016[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 3313[Gecko-windows11-64-25h2-opt] 3316[Gecko-windows11-64-25h2-debug] 3319[Gecko-android-em-14-x86_64-debug-geckoview] 3321[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug] 3323[Gecko-linux2404-64-opt]
FAIL : 6[GitHub] 14[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 72[Gecko-linux2404-64-opt] 74[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug] 76[Gecko-android-em-14-x86_64-debug-geckoview] 79[Gecko-windows11-64-25h2-debug] 82[Gecko-windows11-64-25h2-opt]
Chrome
PASS : 3
CRASH: 1
FAIL : 6
Safari
PASS : 2
FAIL : 8
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/filter-effects/animation/css-backdrop-filters-animation-displacement.html [wpt.fyi]:
FAIL - /css/filter-effects/backdrop-filter-backdrop-root-animation-in-effect.html [wpt.fyi]:
FAIL - /css/filter-effects/backdrop-filter-backdrop-root-mask.html [wpt.fyi]:
FAIL - /css/filter-effects/backdrop-filter-blur-large-value.html [wpt.fyi]:
FAIL - /css/filter-effects/backdrop-filter-edge-clipping-2.html [wpt.fyi]:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-linux2404-64-debug,Gecko-windows11-64-25h2-debug],PASS[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-opt] - /css/filter-effects/backdrop-filter-edge-mirror.html [wpt.fyi]:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-linux2404-64-debug,Gecko-windows11-64-25h2-debug],PASS[Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-opt] - /css/filter-effects/backdrop-filter-inline-positioning.html [wpt.fyi]:
FAIL[Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt] - /css/filter-effects/backdrop-filter-nested-border-radius-clip.html [wpt.fyi]:
FAIL - /css/filter-effects/backdrop-filter-reference-filter.html [wpt.fyi]:
FAIL - /css/filter-effects/backdrop-filter-svg-blur.html [wpt.fyi]:
FAIL - /css/filter-effects/backdrop-filter-svg-displacement.html [wpt.fyi]:
FAIL - /css/filter-effects/backdrop-filter-svg-foreignObject.html [wpt.fyi]:
FAIL - /css/filter-effects/backdrop-filter-with-background-clip-content-box.html [wpt.fyi]:
FAIL - /css/filter-effects/backdrop-filter-with-background-clip-padding-box.html [wpt.fyi]:
FAIL - /css/filter-effects/backdrop-filter-with-mix-blend-mode-same-element.html [wpt.fyi]:
FAIL - /css/filter-effects/background-image-blur-repaint.html [wpt.fyi]:
FAIL[Gecko-windows11-64-25h2-debug],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-opt] - /css/filter-effects/effect-reference-on-span.html [wpt.fyi]:
FAIL[Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt] - /css/filter-effects/empty-element-with-filter-003.html [wpt.fyi]:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt] - /css/filter-effects/feImage-with-hidden-container-defs.html [wpt.fyi]:
FAIL - /css/filter-effects/feImage-with-hidden-container-filter.html [wpt.fyi]:
FAIL - /css/filter-effects/feImage-with-hidden-container-linearGradient.html [wpt.fyi]:
FAIL - /css/filter-effects/feImage-with-hidden-container-mask.html [wpt.fyi]:
FAIL - /css/filter-effects/feImage-with-hidden-container-pattern.html [wpt.fyi]:
FAIL - /css/filter-effects/feImage-with-hidden-container-radialGradient.html [wpt.fyi]:
FAIL - /css/filter-effects/feImage-with-text-viewport-dependence.html [wpt.fyi]:
FAIL - /css/filter-effects/fecomponenttransfer-display-p3.html [wpt.fyi]:
FAIL - /css/filter-effects/feimage-element-ref-geometry.html [wpt.fyi]:
FAIL - /css/filter-effects/feimage-svg-resolution.html [wpt.fyi]:
FAIL(Chrome:PASS, Safari:FAIL) - /css/filter-effects/feimage-svg-root-preserveaspectratio.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/filter-effects/filter-contrast-002.html [wpt.fyi]:
FAIL[Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-debug] - /css/filter-effects/filter-external-001-test.html [wpt.fyi]:
FAIL - /css/filter-effects/filter-external-002-test.html [wpt.fyi]:
FAIL - /css/filter-effects/filter-region-calc-001.html [wpt.fyi]:
FAIL - /css/filter-effects/filter-subregion-01.html [wpt.fyi]:
FAIL - /css/filter-effects/filtered-inline-is-container.html [wpt.fyi]:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt] - /css/filter-effects/svg-empty-hidden-foreignobject-with-filter-001.html [wpt.fyi]:
FAIL - /css/filter-effects/svg-feimage-001.html [wpt.fyi]:
FAIL - /css/filter-effects/svg-feimage-003.html [wpt.fyi]:
FAIL - /css/filter-effects/svg-mutation-function-to-url.html [wpt.fyi]:
FAIL[Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-debug] - /css/filter-effects/svg-mutation-single-to-multiple-001.html [wpt.fyi]:
FAIL[Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-debug] - /css/filter-effects/svg-mutation-single-to-multiple-002.html [wpt.fyi]:
FAIL[Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-debug] - /css/filter-effects/svg-mutation-url-to-function.html [wpt.fyi]:
FAIL[Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-debug] - /css/filter-effects/svg-relative-urls-001.html [wpt.fyi]:
FAIL - /css/filter-effects/svg-shorthand-hue-rotate-001.html [wpt.fyi]:
FAIL[Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-debug] - /css/filter-effects/filter-function/filter-function-001.html [wpt.fyi]:
FAIL - /css/filter-effects/filter-function/filter-function-002.html [wpt.fyi]:
FAIL - /css/filter-effects/filter-function/filter-function-003.html [wpt.fyi]:
FAIL - /css/filter-effects/filter-function/filter-function-005.html [wpt.fyi]:
FAIL - /css/filter-effects/filter-function/filter-function-006.html [wpt.fyi]:
FAIL - /css/filter-effects/filter-function/filter-function-007.html [wpt.fyi]:
FAIL - /css/filter-effects/filter-function/filter-function-conic-gradient.html [wpt.fyi]:
FAIL - /css/filter-effects/filter-function/filter-function-linear-gradient.html [wpt.fyi]:
FAIL - /css/filter-effects/filter-function/filter-function-radial-gradient.html [wpt.fyi]:
FAIL - /css/filter-effects/filter-function/filter-function-repeating-conic-gradient.html [wpt.fyi]:
FAIL - /css/filter-effects/filter-function/filter-function-repeating-linear-gradient.html [wpt.fyi]:
FAIL - /css/filter-effects/filter-function/filter-function-repeating-radial-gradient.html [wpt.fyi]:
FAIL - /svg/styling/css-linked-parameters/css-linked-parameters-precedence-1.html [wpt.fyi]:
FAIL - /svg/styling/css-linked-parameters/css-linked-parameters-precedence-2.html [wpt.fyi]:
FAIL - /svg/styling/css-linked-parameters/img-with-linked-parameters-2.html [wpt.fyi]:
FAIL - /svg/styling/css-linked-parameters/img-with-url-fragment-identifiers-1.html [wpt.fyi]:
FAIL - /svg/styling/css-linked-parameters/img-with-url-fragment-identifiers-2.html [wpt.fyi]:
FAIL - /svg/styling/css-linked-parameters/img-with-url-function-1.html [wpt.fyi]:
FAIL - /svg/styling/css-linked-parameters/img-with-url-function-2.html [wpt.fyi]:
FAIL - /svg/styling/css-linked-parameters/link-parameters-currentcolor-typed.html [wpt.fyi]:
FAIL - /svg/styling/css-linked-parameters/link-parameters-duplicate-name.html [wpt.fyi]:
FAIL - /svg/styling/css-linked-parameters/link-parameters-feimage-dynamic.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /svg/styling/css-linked-parameters/link-parameters-feimage-resolution.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /svg/styling/css-linked-parameters/link-parameters-feimage-subregion.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /svg/styling/css-linked-parameters/link-parameters-feimage.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /svg/styling/css-linked-parameters/link-parameters-geometry.html [wpt.fyi]:
FAIL - /svg/styling/css-linked-parameters/link-parameters-invalid-typed-value.html [wpt.fyi]:
FAIL - /css/filter-effects/animation/filter-interpolation-002.html [wpt.fyi]
- CSS Transitions: property <filter> from [drop-shadow(20px 10px blue)] to [drop-shadow(20px 10px green)] at (2147483648) should be [drop-shadow(20px 10px #00FF00]:
FAIL - CSS Transitions with transition: all: property <filter> from [drop-shadow(20px 10px blue)] to [drop-shadow(20px 10px green)] at (2147483648) should be [drop-shadow(20px 10px #00FF00]:
FAIL - CSS Animations: property <filter> from [drop-shadow(20px 10px blue)] to [drop-shadow(20px 10px green)] at (2147483648) should be [drop-shadow(20px 10px #00FF00]:
FAIL - Web Animations: property <filter> from [drop-shadow(20px 10px blue)] to [drop-shadow(20px 10px green)] at (2147483648) should be [drop-shadow(20px 10px #00FF00]:
FAIL
- CSS Transitions: property <filter> from [drop-shadow(20px 10px blue)] to [drop-shadow(20px 10px green)] at (2147483648) should be [drop-shadow(20px 10px #00FF00]:
- /css/filter-effects/idlharness.any.html [wpt.fyi]
- SVGFEGaussianBlurElement interface: constant SVG_EDGEMODE_UNKNOWN on interface object:
FAIL - SVGFEGaussianBlurElement interface: constant SVG_EDGEMODE_UNKNOWN on interface prototype object:
FAIL - SVGFEGaussianBlurElement interface: constant SVG_EDGEMODE_DUPLICATE on interface object:
FAIL - SVGFEGaussianBlurElement interface: constant SVG_EDGEMODE_DUPLICATE on interface prototype object:
FAIL - SVGFEGaussianBlurElement interface: constant SVG_EDGEMODE_WRAP on interface object:
FAIL - SVGFEGaussianBlurElement interface: constant SVG_EDGEMODE_WRAP on interface prototype object:
FAIL - SVGFEGaussianBlurElement interface: constant SVG_EDGEMODE_NONE on interface object:
FAIL - SVGFEGaussianBlurElement interface: constant SVG_EDGEMODE_NONE on interface prototype object:
FAIL - SVGFEGaussianBlurElement interface: attribute edgeMode:
FAIL - SVGFEImageElement interface: attribute crossOrigin:
FAIL
- SVGFEGaussianBlurElement interface: constant SVG_EDGEMODE_UNKNOWN on interface object:
Comment 4•5 days ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/75d514b133cf
https://hg.mozilla.org/mozilla-central/rev/0a7e6ee4968e
Description
•