Closed Bug 2089385 Opened 13 days ago Closed 4 days ago

[wpt-sync] Sync PR 64423 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=327540

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 64423 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64423
Details from upstream follow.

Sam Weinig <sam@webkit.org> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=327540

WebKit export from bug: [<!---->Image Redux]<!----> Unify rules for sizing SVG images with 0 width or height

<pre>
[Image Redux] Unify rules for sizing SVG images with 0 width or height

Previously, RenderImage and RenderEmbeddedObject each overrode shouldRespectZeroIntrinsicWidth()/Height() with their own rule for
when a natural width or height of 0 is respected. Instead, we now have a single implementation in RenderReplaced using the virtual
natural dimensions accessor. To make that accessor meaningful for every replaced element, RenderReplaced::zoomedNaturalDimensions()
is now pure virtual and each subclass has to declare its own natural dimensions.

Additionally, an SVG's natural dimensions took its aspect ratio from the width and height even when one of them is 0. That ratio is
considered degenerate, so it now falls back to the viewBox as the CSS WG resolved in <a href="https://github.com/w3c/csswg-drafts/issues/6286.">https://github.com/w3c/csswg-drafts/issues/6286.</a>

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=327540">https://bugs.webkit.org/show_bug.cgi?id=327540</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/323884@main">https://commits.webkit.org/323884@main</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Layout
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Attached file Notable wpt changes —

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1327 tests

Status Summary

Firefox

OK : 1[GitHub] 278[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 13[GitHub] 14[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 9207[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 10131[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 10133[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL : 2[GitHub] 671[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 775[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 777[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
TIMEOUT: 3
ERROR : 3

Chrome

OK : 1
PASS : 13
FAIL : 2

Safari

OK : 1
PASS : 14
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

(See attachment for full changes)

Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: