Closed Bug 2089387 Opened 13 days ago Closed 4 days ago

[wpt-sync] Sync PR 64424 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=327417

Categories

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64424 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64424
Details from upstream follow.

Sam Weinig <sam@webkit.org> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=327417

WebKit export from bug: [<!---->Image Redux]<!----> Add support for '<!---->object-<!---->fit'<!---->,<!----> '<!---->object-<!---->position'<!----> and '<!---->object-<!---->view-<!---->box`<!----> for SVG documents in \<<!---->embed><!----> and \<<!---->object><!---->

<pre>
[Image Redux] Add support for 'object-fit', 'object-position' and 'object-view-box` for SVG documents in <embed> and <object>

Adds support for 'object-fit', 'object-position' and 'object-view-box` for SVG documents in <embed> and <object>
using the recently added natural dimensions infrastructure.

Moved RenderImage::imagePaintRect() down to RenderReplaced and renamed to RenderReplaced::replacedContentPaintRect(),
so that it can be used with RenderWidget as well.

Hit testing, repaints and coordinate conversions for the child frame now use RenderWidget::widgetContentLocation()
which accounts for 'object-fit' and 'object-position'.

Removes 66 tests from TestExpectations and adds a few more that I wrote to make sure content changes worked correctly.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=327417">https://bugs.webkit.org/show_bug.cgi?id=327417</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/323822@main">https://commits.webkit.org/323822@main</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Layout: Images, Video, and HTML Frames
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 519 tests

Status Summary

Firefox

OK : 42
PASS: 4[GitHub] 6[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 3512[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 3930[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 1[GitHub] 89[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 140[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 2
FAIL: 3

Safari

FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.