Closed Bug 2089391 Opened 16 days ago Closed 8 days ago

[wpt-sync] Sync PR 64429 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=323558

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64429 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64429
Details from upstream follow.

Simon Fraser <simon.fraser@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=323558

WebKit export from bug: [<!---->corner-<!---->shape]<!----> Outlines with negative offset look ugly

<pre>
[corner-shape] Outlines with negative offset look ugly

Bevel, notch and square corners are adjusted for insets (e.g. for an outline with
negative inset) by offsetting the border-box corner at constant thickness rather than by
scaling their radius (rebuildOffsetCornersFromReference). There were three issues for a
negative (inset) offset:

The rebuilt corner follows the border-box curve, so it extends past the edges of the
rect it is being offset relative to. The inner contour already trimmed to that rect, but
the outer one did not, resulting in uneven thickness of inset outlines on bevel corners.

When the inset outline becomes empty, we now detect that we should draw nothing.

Fix a rendering issue when the inset is larger than the notch size.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=323558">https://bugs.webkit.org/show_bug.cgi?id=323558</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/321259@main">https://commits.webkit.org/321259@main</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 181 tests

Status Summary

Firefox

OK : 19
PASS: 1[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 3[GitHub] 878[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 979[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 2[GitHub] 107[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 167[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 4
FAIL: 1

Safari

PASS: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 8 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.