[wpt-sync] Sync PR 64442 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=315324
Categories
(Core :: Layout: Block and Inline, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 64442 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/64442
Details from upstream follow.
Alan Baradlay <zalan@apple.com> wrote:
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=315324
WebKit export from bug: [<!---->block-<!---->in-<!---->inline]<!----> inline-<!---->block baseline should fall back to bottom margin edge when content inside is block-<!---->in-<!---->inline only
<pre>
[block-in-inline] inline-block baseline should fall back to bottom margin edge when content inside is block-in-inline only<span>text
<div style="display: inline-block; width: 320px; height: 100px;">
<span><div style="display: block; width: 320px; height: 100px;"></div></span>
</div>
</span>The "text" should sit at the bottom of the inline-block. The inline-block's
baseline should be its bottom margin edge per CSS 2.1 10.8.1 (and CSS Inline 3
atomic-inline baseline synthesis), since the only content is block-in-inline
and there are no in-flow line boxes with a baseline. Instead the "text" sat
at the top of the inline-block.In LayoutIntegrationBoxGeometryUpdater::baselineForBox, the RenderBlockFlow
path called LineLayout::lastLineBaseline() which correctly returns nullopt
when no line contributes a baseline (e.g. when the only content is a
block-in-inline whose inner block is empty). The integration was substituting
0 via .value_or(0_lu) and reporting the inline-block's top edge as its
baseline.Drop the .value_or(0_lu) so the nullopt propagates: setIntegrationBaseline's
existing fallback then synthesizes margin-box-bottom for atomic inlines (per
css-inline-3 A.3), and lastInflowBoxBaseline's sibling walk skips the
non-contributing child and continues to the previous in-flow block-level
sibling (per css-align-3 §11.5).LineLayout::lastLineBaseline already recurses into block-in-inline via
blockLevelBoxForLine, so when the inner block does contribute a last baseline
the inline-block aligns to it (covered by css/css-lists/list-and-block-in-inline.html)WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=315324">https://bugs.webkit.org/show_bug.cgi?id=315324</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/313769@main">https://commits.webkit.org/313769@main</a>
</pre>
| Assignee | ||
Updated•15 days ago
|
| Assignee | ||
Updated•10 days ago
|
| Assignee | ||
Updated•10 days ago
|
| Assignee | ||
Comment 1•10 days ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=116779
| Assignee | ||
Comment 2•10 days ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 436 tests
Status Summary
Firefox
OK : 59
PASS: 2[GitHub] 7[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 842[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 1122[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 1125[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 20[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 107[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
Chrome
PASS: 2
Safari
PASS: 2
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-inline/initial-letter/Initial-letter-breaking-rtl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/Initial-letter-breaking-vlr.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/Initial-letter-breaking-vrl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/Initial-letter-breaking.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-drop-over-ruby-tall.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-drop-over-ruby.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-drop-under-ruby-tall.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-drop-under-ruby.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-fractional-drop-vlr.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-fractional-drop-vrl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-fractional-drop.html [wpt.fyi]:
FAIL - /css/css-inline/text-box-trim/new-fc-001.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-fractional-size-vlr.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-fractional-size-vrl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-fractional-size.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-margins-rtl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-margins-slr.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-margins-srl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-margins-vlr.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-margins-vrl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-margins.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-over-sunk-vlr.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-over-sunk-vrl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-over-sunk.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-raise-over-ruby-tall.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-raise-over-ruby.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-raise-under-ruby-tall.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-block-position-raise-under-ruby.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-breaking-slr.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-breaking-srl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-drop-initial-rtl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-drop-initial-slr.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-drop-initial-srl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-drop-initial-vlr.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-drop-initial-vrl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-drop-initial.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-float-001-rtl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-float-001-slr.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-float-001-srl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-float-001-vlr.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-float-001-vrl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-float-001.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-float-002.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-float-003.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-float-004.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-float-005.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-indentation-rtl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-indentation.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-layout-text-decoration-underline.html [wpt.fyi]:
FAIL - /css/css-inline/text-box-trim/text-box-trim-first-line-pseudo-002.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-raise-initial-slr.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-raise-initial-srl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-raise-initial-vlr.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-raise-initial-vrl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-raise-initial.html?class= [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-raise-initial.html?class=no-descent [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-raise-initial.html?class=rtl [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-raise-initial.html?class=no-ascent [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-raised-sunken-caps-raise.html [wpt.fyi]:
FAIL - /css/css-inline/text-box-trim/text-box-trim-half-leading-block-box-003.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-raised-sunken-caps-sunken.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-short-para-initial-letter-clears.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-short-para-initial-letter-wraps.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-sunk-initial-slr.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-sunk-initial-srl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-sunk-initial-vlr.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-sunk-initial-vrl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-sunk-initial.html?class= [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-sunk-initial.html?class=rtl [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-sunk-initial.html?class=no-ascent [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-sunk-initial.html?class=no-descent [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-with-first-line.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-with-tab-rtl.html [wpt.fyi]:
FAIL - /css/css-inline/initial-letter/initial-letter-with-tab.html [wpt.fyi]:
FAIL - /css/css-inline/alignment-baseline/alignment-baseline-horizontal-001.html?class=middle [wpt.fyi]:
FAIL - /css/css-inline/alignment-baseline/alignment-baseline-horizontal-002.html?class=middle [wpt.fyi]:
FAIL - /css/css-inline/alignment-baseline/alignment-baseline-horizontal-003.html?class=middle [wpt.fyi]:
FAIL - /css/css-inline/text-box-trim/text-box-trim-line-clamp-001.html [wpt.fyi]:
FAIL - /css/css-inline/text-box-trim/text-box-trim-line-clamp-002.html [wpt.fyi]:
FAIL - /css/css-inline/text-box-trim/text-box-trim-line-clamp-auto-001.html [wpt.fyi]:
FAIL - /css/css-inline/text-box-trim/text-box-trim-line-clamp-auto-002.html [wpt.fyi]:
FAIL - /css/css-inline/text-box-trim/text-box-trim-line-clamp-auto-block-in-inline-001.html [wpt.fyi]:
FAIL - /css/css-inline/text-box-trim/text-box-trim-line-clamp-auto-block-in-inline-002.html [wpt.fyi]:
FAIL - /css/css-inline/text-box-trim/text-box-trim-multicol-009.html [wpt.fyi]:
FAIL - /css/css-inline/text-box-trim/text-box-trim-multicol-012.html [wpt.fyi]:
FAIL - /css/css-inline/alignment-baseline/alignment-baseline-vertical-rl-002.html?class=middle [wpt.fyi]:
FAIL - /css/css-inline/alignment-baseline/alignment-baseline-vertical-rl-003.html?class=middle [wpt.fyi]:
FAIL - /css/css-inline/baseline-source/baseline-source-first-002.html [wpt.fyi]
- .target > * 19:
FAIL - .target > * 21:
FAIL
- .target > * 19:
- /css/css-inline/baseline-source/baseline-source-last-002.html [wpt.fyi]
- .target > * 19:
FAIL - .target > * 21:
FAIL
- .target > * 19:
- /css/css-inline/initial-letter/initial-letter-computed.html [wpt.fyi]
- Property initial-letter value '1.23 drop':
FAIL - Property initial-letter value '1.23 raise':
FAIL - Property initial-letter value 'drop 1.23':
FAIL - Property initial-letter value 'raise 1.23':
FAIL
- Property initial-letter value '1.23 drop':
- /css/css-inline/initial-letter/initial-letter-valid.html [wpt.fyi]
- e.style['initial-letter'] = "1.23 drop" should set the property value:
FAIL - e.style['initial-letter'] = "1.23 raise" should set the property value:
FAIL - e.style['initial-letter'] = "drop 1.23" should set the property value:
FAIL - e.style['initial-letter'] = "raise 1.23" should set the property value:
FAIL
- e.style['initial-letter'] = "1.23 drop" should set the property value:
- /css/css-inline/inheritance.html [wpt.fyi]
- Property initial-letters has initial value normal:
FAIL - Property initial-letters does not inherit:
FAIL - Property initial-letters-align has initial value alphabetic:
FAIL - Property initial-letters-align inherits:
FAIL - Property initial-letters-wrap has initial value none:
FAIL - Property initial-letters-wrap inherits:
FAIL - Property initial-sizing has initial value normal:
FAIL - Property initial-sizing does not inherit:
FAIL
- Property initial-letters has initial value normal:
Comment 4•6 days ago
|
||
| bugherder | ||
Comment 5•6 days ago
|
||
| bugherder | ||
Description
•