Closed Bug 2089410 Opened 12 days ago Closed 4 days ago

[wpt-sync] Sync PR 64444 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=312252

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox162 fixed)

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64444 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64444
Details from upstream follow.

Yoav Weiss <yoav.weiss@shopify.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=312252

WebKit export from bug: Speculation Rules -<!----> race condition with non-<!---->OK responses leads to wrong response being served

<pre>
Speculation Rules - Fix race conditions with non-OK responses

While the speculation rules implementation properly handled non-2XX status responses that came to completion,
it failed to handle responses that were not done before the navigation request for them was triggered.
This PR fixes that by:

  • Ensuring that a failed response gets evicted from the memory cache even before it's done.
  • Avoiding to commit and retrying a navigation request if its prefetch response has failed.
  • Properly clearing prefetched resources when the DocumentPrefetcher gets destructed. (lack of that cleanup caused issues in some of the new test scenarios)

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=312252">https://bugs.webkit.org/show_bug.cgi?id=312252</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/311445@main">https://commits.webkit.org/311445@main</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 218 tests and 1 subtests

Status Summary

Firefox

OK : 3[GitHub] 214[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 215[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-windows11-32-25h2-opt] 216[Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 217[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
PASS: 3[GitHub] 180[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 181[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-windows11-32-25h2-opt] 182[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 69[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 70[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]

Chrome

OK : 3
PASS: 3

Safari

OK : 3
PASS: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.