Closed Bug 2089411 Opened 13 days ago Closed 5 days ago

[wpt-sync] Sync PR 64441 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=316108

Categories

(Core :: Layout: Text and Fonts, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64441 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64441
Details from upstream follow.

Alan Baradlay <zalan@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=316108

WebKit export from bug: Line-<!---->through is too thin over a descendant inline box

<pre>
Line-through is too thin over a descendant inline box

<div style="text-decoration: line-through; text-decoration-thickness: 30px">
1<span>2</span>3
</div>

The line-through should be 30px thick across 1, 2 and 3. Instead the segment
over the <span> (2) was a thin line: its thickness came from the span, whose
text-decoration-thickness is auto, rather than from the div that set the
line-through.

When painting a line-through, paintForegroundDecorations took the thickness,
position and color from the text's direct parent inline box. For text inside an
inline box that does not itself set the decoration that parent is the wrong box,
since the decoration was established by an ancestor.

paintForegroundDecorations now collects the decorating boxes by walking the
inline box ancestors and paints the line-through using the style of the box that
established it, one per decorating box. This mirrors what the background
(underline/overline) path already does, which is why those were unaffected.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=316108">https://bugs.webkit.org/show_bug.cgi?id=316108</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/314391@main">https://commits.webkit.org/314391@main</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 370 tests

Status Summary

Firefox

OK : 48
PASS: 4[GitHub] 9[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 1374[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 1664[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 1666[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 1667[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 11[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 31[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 32[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 33[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]

Chrome

PASS: 4

Safari

PASS: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Status: NEW → RESOLVED
Closed: 5 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.