Closed Bug 2089417 Opened 13 days ago Closed 4 days ago

[wpt-sync] Sync PR 64447 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=257369

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64447 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64447
Details from upstream follow.

Ian Gower <i_gower@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=257369

WebKit export from bug: [<!---->css-<!---->counter-<!---->styles]<!----> Support CJK counter styles outside of range

<pre>
[css-counter-styles] Support the extended range for the longhand East Asian counter styles

The nine longhand East Asian counter styles stopped at -9999 to 9999, so a list numbered
past 9999 dropped to cjk-decimal partway down. Chrome and Firefox already number the
Chinese and Korean styles over the extended range.

counterForSystemCJK only implemented the Chinese form of the algorithm, and the Japanese
and Korean styles were built out of additive-symbols, which cannot reach past one group of
four digits. Therefore the algorithm now takes the language and the formality, and the
Japanese and Korean styles get internal systems like the Chinese ones already have. The
negative sign now comes from the negative descriptor, because the Japanese and Korean signs
are four characters long and every other system already works that way. The output buffer
has room for two characters per abstract character, because the simplified Chinese fourth
group marker is spelled with two and the old one held a single character of each.

Resync the nine reference files corrected by web-platform-tests/wpt#54469. WebKit imported
this directory on 2025-08-21, twelve days before that landed, so the copies here still
expect the informal "drop ones" rule in the formal styles and spell the Korean styles with
characters from the Chinese and hangul ones.

Cover the range with reference tests in css/css-counter-styles, one per style, rather than a
layout test. Section 7.1.2 is optional, so they carry the .optional filename flag, and they
go upstream next. The values stay inside what a counter value can hold, so the rows are all
defined by the algorithm rather than by where an engine truncates.

A counter value is an int, so the reachable part of the new range stops at 2147483647.
Reaching the rest of it needs a wider counter value, which is separate work.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=257369">https://bugs.webkit.org/show_bug.cgi?id=257369</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/320887@main">https://commits.webkit.org/320887@main</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 69 tests

Status Summary

Firefox

PASS: 52
FAIL: 10[GitHub] 17[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 7
FAIL: 3

Safari

PASS: 10

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.