Closed Bug 2089430 Opened 13 days ago Closed 4 days ago

[wpt-sync] Sync PR 64459 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=315560

Categories

(Core :: Layout: Text and Fonts, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64459 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64459
Details from upstream follow.

Alan Baradlay <zalan@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=315560

WebKit export from bug: Line break should not appear after U+<!---->201D Right Double Quotation Mark

<pre>
Line break should not appear after U+201D Right Double Quotation Mark

<div style="font-family: Monospace; max-inline-size: 2em">1 &rdquo;2</div>

The text should wrap as "1" on the first line and "&rdquo;2" on the second.
Instead it wrapped as "1 &rdquo;" on the first line and "2" alone on the
second.

BreakablePositions::classify mapped the single curly quotes (U+2018 and
U+2019) to the kQU line break class but missed the double curly quotes.
U+201C and U+201D fell through to kWeird and were deferred to ICU.
Current ICU returned a break opportunity right after U+201D
(predates LB19a which prohibits breaks adjacent to QU when neighbors are not East Asian;
LB19a was added in ICU 76)

The fix adds Pi/Pf sub-flags to the QU class and implements LB19/LB19a
directly in the fast path. Curly quotes and the angle quotation marks now
classify as kQU|kPi (initial) or kQU|kPf (final). When neither neighbor is
East Asian, LB19a forbids the break either side. When one neighbor is East
Asian, LB19's [QU - Pi] / [QU - Pf] split decides: break before is allowed
only for an initial-class QU, break after is allowed only for a
final-class QU. No ICU lookup is needed for QU pairs.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=315560">https://bugs.webkit.org/show_bug.cgi?id=315560</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/314829@main">https://commits.webkit.org/314829@main</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 90 tests

Status Summary

Firefox

OK : 1
PASS: 1[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 3[GitHub] 86[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 2[GitHub] 4[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 5

Safari

PASS: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.