Closed Bug 2089432 Opened 12 days ago Closed 4 days ago

[wpt-sync] Sync PR 64458 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=325844

Categories

(Core :: Layout: Scrolling and Overflow, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64458 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64458
Details from upstream follow.

Alan Baradlay <zalan@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=325844

WebKit export from bug: REGRESSION(<!---->291542@<!---->main)<!---->:<!----> Layout stops updating inside nested scroll container after its classic scrollbar disappears (<!---->-<!---->webkit-<!---->line-<!---->clamp +<!----> absolutely positioned descendant)<!---->

<pre>
REGRESSION(<a href="https://commits.webkit.org/291542@main">291542@main</a>): Layout stops updating inside nested scroll container after its classic scrollbar disappears (-webkit-line-clamp + absolutely positioned descendant)

<div style="display: grid; height: 300px">
<div style="overflow-y: auto">
<div style="height: 100%; overflow-y: auto">
<div style="display: -webkit-box; -webkit-box-orient: vertical; -webkit-line-clamp: 1">
<span style="display: block; position: relative">Row<span style="position: absolute; inset: 0"></span></span>

Rows added to the inner scroller should be laid out. Instead, once its classic
scrollbar had come or gone, new rows stayed 0px tall until the window was resized.

The grid runs the inner scroller's scrollbar relayout after both scrollers have
finished layout. In that relayout, line-clamp dirties the absolutely positioned
box together with its containing block chain, which leaves the outer scroller
needing layout under a clean grid, so every later change stops at it (since
<a href="https://commits.webkit.org/291542@main">291542@main</a> this mark is normalChildNeedsLayout; before, it was a simplified
layout bit that other changes went past).

The clamp lays its child out right after dirtying it, and the child lays out its
out-of-flow boxes, so only dirty the boxes themselves.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=325844">https://bugs.webkit.org/show_bug.cgi?id=325844</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/324368@main">https://commits.webkit.org/324368@main</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Layout: Scrolling and Overflow
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 354 tests

Status Summary

Firefox

OK : 1[GitHub] 3[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 1[GitHub] 12[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 16[Gecko-windows11-32-25h2-debug] 271[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 274[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 81[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 84[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.