Closed Bug 2089434 Opened 13 days ago Closed 5 days ago

[wpt-sync] Sync PR 64465 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=262111

Categories

(Core :: Layout: Tables, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64465 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64465
Details from upstream follow.

Alan Baradlay <zalan@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=262111

WebKit export from bug: Broken '<!---->button'<!----> layout with display:<!---->table on www.<!---->weekly10.<!---->com

<pre>
Broken 'button' layout with display:table on www.weekly10.com

When a table is a flex or grid item, the container can stretch it to
match the tallest sibling. The stretched height is a "border-box"
value -- it includes the table's border and padding on all sides.

To figure out how much space the rows get, we need to subtract the
border and padding from this stretched height. The code was only
subtracting the bottom border+padding, forgetting the top side.
So the table ended up too tall by exactly one side of padding
(or border).

This includes the lint fixes from <a href="https://commits.webkit.org/325383@main.">https://commits.webkit.org/325383@main.</a>

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=262111">https://bugs.webkit.org/show_bug.cgi?id=262111</a>
WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=329678">https://bugs.webkit.org/show_bug.cgi?id=329678</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/311276@main">https://commits.webkit.org/311276@main</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Layout: Tables
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 350 tests

Status Summary

Firefox

OK : 1[GitHub] 136[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 6[GitHub] 41[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 860[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 1006[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 1014[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 95[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 114[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 116[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]

Chrome

OK : 1
PASS: 6

Safari

OK : 1
PASS: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 5 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.