[wpt-sync] Sync PR 64464 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=226002
Categories
(Core :: Layout: Tables, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 64464 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/64464
Details from upstream follow.
Alan Baradlay <zalan@apple.com> wrote:
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=226002
WebKit export from bug: [<!---->Table]<!----> Incorrect distributed height when \<<!---->td><!----> height is set
<pre>
[Table] Incorrect distributed height when <td> height is setWhen a table has a CSS height larger than its content, the extra height
should be distributed to rows. This works for rows with auto height, but
fails for rows with an explicit height (e.g. <td height=1px>). Instead
of reaching 100px, the table ends up shorter.The problem is in distributeRemainingExtraLogicalHeight, which
distributes leftover height proportionally to existing row sizes. It used
m_rowPos[totalRows] as the total size, but m_rowPos includes
border-spacing -- both the initial spacing before the first row and the
spacing between rows. When computing each row's share, the spacing
portion absorbs some of the extra height that should go entirely to rows.For example, with one row of height 4px and border-spacing 2px:
totalRowSize = 6 (includes 2px spacing), row share = 94 * 4/6 = 62.66.
The remaining 31px is silently lost.The fix adds a rowLogicalHeight() helper that returns the actual row
height excluding border-spacing, and uses it for proportional
distribution. Row heights are pre-computed into a vector before the
distribution loop since the loop modifies m_rowPos (reading
rowLogicalHeight during the loop would use already-modified values,
producing wildly negative weights). When all rows are zero-height,
it distributes equally instead of doing nothing.Also fixed the same spacing-included-in-row-height issue in
distributeExtraLogicalHeightToPercentRows.This includes the lint fixes from <a href="https://commits.webkit.org/325383@main.">https://commits.webkit.org/325383@main.</a>
WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=226002">https://bugs.webkit.org/show_bug.cgi?id=226002</a>
WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=329678">https://bugs.webkit.org/show_bug.cgi?id=329678</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/311001@main">https://commits.webkit.org/311001@main</a>
</pre>
| Assignee | ||
Updated•14 days ago
|
| Assignee | ||
Updated•9 days ago
|
| Assignee | ||
Updated•9 days ago
|
| Assignee | ||
Comment 1•9 days ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=117181
| Assignee | ||
Comment 2•9 days ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 351 tests
Status Summary
Firefox
OK : 1[GitHub] 136[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 3[GitHub] 41[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 856[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 1003[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 1011[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 95[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 114[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 116[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
Chrome
OK : 1
PASS: 3
Safari
OK : 1
PASS: 3
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-tables/absolute-tables-008.tentative.html [wpt.fyi]:
FAIL - /css/css-tables/absolute-tables-009.tentative.html [wpt.fyi]:
FAIL - /css/css-tables/absolute-tables-010.tentative.html [wpt.fyi]:
FAIL - /css/css-tables/absolute-tables-011.tentative.html [wpt.fyi]:
FAIL - /css/css-tables/collapsed-border-positioned-tr-td.html [wpt.fyi]:
FAIL - /css/css-tables/fixup-dynamic-anonymous-inline-table-003.html [wpt.fyi]:
FAIL - /css/css-tables/table-cell-overflow-auto-scrolled.html [wpt.fyi]:
FAIL - /css/css-tables/visibility-collapse-border-spacing-001.html [wpt.fyi]:
FAIL - /css/css-tables/visibility-collapse-colspan-003.html [wpt.fyi]:
FAIL - /css/css-tables/visibility-collapse-rowspan-005.html [wpt.fyi]:
FAIL - /css/css-tables/height-distribution/percentage-sizing-of-table-cell-007.html [wpt.fyi]:
FAIL - /css/css-tables/height-distribution/percentage-sizing-of-table-cell-children-002.html [wpt.fyi]:
FAIL - /css/css-tables/height-distribution/percentage-sizing-of-table-cell-replaced-children-001.html [wpt.fyi]:
FAIL - /css/css-tables/tentative/border-collapse-spanning-cells-004.html [wpt.fyi]:
FAIL - /css/css-tables/tentative/collapsed-borders-painting-order-002.html [wpt.fyi]:
FAIL - /css/css-tables/tentative/collapsed-borders-painting-order-003.html [wpt.fyi]:
FAIL - /css/css-tables/tentative/collapsed-borders-painting-order-008.html [wpt.fyi]:
FAIL - /css/css-tables/tentative/collapsed-borders-painting-order-011.html [wpt.fyi]:
FAIL - /css/css-tables/tentative/section-no-tbody-fixed-distribution.html [wpt.fyi]:
FAIL - /css/css-tables/tentative/section-no-tbody-percent-distribution.html [wpt.fyi]:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - /css/css-tables/bounding-box-computation-3.html [wpt.fyi]
- Control test: Table height is 120px:
FAIL - First (empty) table-row-group is 0px wide:
FAIL - Second table-row-group should be located at 10px top:
FAIL
- Control test: Table height is 120px:
- /css/css-tables/caption-orthogonal-block-start-margin.html [wpt.fyi]
- A caption in the table's writing mode is offset by its block-start margin:
FAIL - A caption in an orthogonal writing mode is offset by its block-start margin:
FAIL
- A caption in the table's writing mode is offset by its block-start margin:
- /css/css-tables/caption-orthogonal-margin-in-table-block-axis.html [wpt.fyi]
- A caption in the table's writing mode adds its horizontal margins to the table's block size:
FAIL - A caption in an orthogonal writing mode adds its horizontal margins to the table's block size:
FAIL
- A caption in the table's writing mode adds its horizontal margins to the table's block size:
- /css/css-tables/caption-side-1.html [wpt.fyi]
- Multiple captions can be rendered:
FAIL
- Multiple captions can be rendered:
- /css/css-tables/caption-writing-mode-001.html [wpt.fyi]
- Caption with auto top/bottom margins is centered vertically for vertical-lr tables:
FAIL
- Caption with auto top/bottom margins is centered vertically for vertical-lr tables:
- /css/css-tables/column-track-merging.html [wpt.fyi]
- main table 5:
FAIL - main table 12:
FAIL
- main table 5:
- /css/css-tables/html-to-css-mapping-2.html [wpt.fyi]
- 1: HTML -> CSS Mapping for borders is applied correctly on table markup (table left color):
FAIL - 2: HTML -> CSS Mapping for borders is applied correctly on table markup (table left width):
FAIL - 3a: HTML -> CSS Mapping for borders is applied correctly on table markup (table left color):
FAIL - 3b: HTML -> CSS Mapping for borders is applied correctly on table markup (td top width):
FAIL - 3b: HTML -> CSS Mapping for borders is applied correctly on table markup (td top style):
FAIL - 3b: HTML -> CSS Mapping for borders is applied correctly on table markup (td top color):
FAIL - 3c: HTML -> CSS Mapping for borders is applied correctly on table markup (td left width):
FAIL - 3c: HTML -> CSS Mapping for borders is applied correctly on table markup (td left style):
FAIL - 3c: HTML -> CSS Mapping for borders is applied correctly on table markup (td left color):
FAIL - 4: HTML -> CSS Mapping for borders is applied correctly on table markup (table left color):
FAIL - 4: HTML -> CSS Mapping for borders is applied correctly on table markup (td left color):
FAIL - 5b: HTML -> CSS Mapping for borders is applied correctly on table markup (table right color):
FAIL
- 1: HTML -> CSS Mapping for borders is applied correctly on table markup (table left color):
- /css/css-tables/html5-table-formatting-1.html [wpt.fyi]
- Empty tables do not take table-columns into account:
FAIL
- Empty tables do not take table-columns into account:
- /css/css-tables/html5-table-formatting-3.html [wpt.fyi]
- Explicitely-defined consecutive columns spanned by the same set of cells are not merged:
FAIL - Explicitely-defined consecutive columns spanned by the same set of cells are not merged, and cells span across border-spacing:
FAIL - Explicitely-defined consecutive rows spanned by the same set of cells are not merged, and cells span across border-spacing:
FAIL
- Explicitely-defined consecutive columns spanned by the same set of cells are not merged:
- /css/css-tables/percent-height-overflow-auto-in-restricted-block-size-cell.html [wpt.fyi]
- #container 1:
FAIL
- #container 1:
- /css/css-tables/percent-width-ignored-002.tentative.html [wpt.fyi]
- #stf 1:
FAIL
- #stf 1:
- /css/css-tables/height-distribution/percentage-sizing-of-table-cell-children.html [wpt.fyi]
- Percentages resolve based on the row height:
FAIL - Percentages resolve based on the final row height:
FAIL - Unresolvable percentage widths are resolved as auto in first pass (replaced elements):
FAIL - Unresolvable percentage heights are resolved as 0px in first pass (scrollable overflow):
FAIL
- Percentages resolve based on the row height:
- /css/css-tables/tentative/baseline-table.html [wpt.fyi]
- .container 11:
FAIL - .container 13:
FAIL
- .container 11:
- /css/css-tables/tentative/baseline-td.html [wpt.fyi]
- table, .display-table 3:
FAIL
- table, .display-table 3:
- /css/css-tables/tentative/caption.html [wpt.fyi]
- table 1:
FAIL - table 2:
FAIL - table 3:
FAIL - table 4:
FAIL - table 5:
FAIL - table 8:
FAIL - table 9:
FAIL - table 10:
FAIL - table 12:
FAIL - table 13:
FAIL
- table 1:
- /css/css-tables/tentative/colspan-redistribution.html [wpt.fyi]
- table 5:
FAIL - table 26:
FAIL - table 29:
FAIL - table 30:
FAIL - table 31:
FAIL
- table 5:
- /css/css-tables/tentative/rowspan-height-redistribution.html [wpt.fyi]
- table 7:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - table 8:
FAIL - table 10:
FAIL - table 18:
FAIL - table 20:
FAIL
- table 7:
- /css/css-tables/tentative/table-height-redistribution.html [wpt.fyi]
- table 5:
FAIL - table 7:
FAIL - table 10:
FAIL - table 11:
FAIL - table 12:
FAIL - table 14:
FAIL - table 17:
FAIL - table 18:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - table 19:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - table 20:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - table 21:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - table 22:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - table 25:
FAIL - table 27:
FAIL - table 28:
FAIL - table 29:
FAIL - table 30:
FAIL - table 31:
FAIL
- table 5:
- /css/css-tables/tentative/table-quirks.html [wpt.fyi]
- table 5:
FAIL
- table 5:
- /css/css-tables/tentative/table-rows-with-zero-columns.html [wpt.fyi]
- tr 1:
FAIL[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview] - tr 2:
FAIL[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview] - tr 3:
FAIL[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview] - tr 4:
FAIL - tr 5:
FAIL - tr 6:
FAIL - tr 7:
FAIL[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview] - tr 8:
FAIL[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview] - tr 9:
FAIL[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview] - tr 10:
FAIL - tr 11:
FAIL - tr 12:
FAIL
- tr 1:
- /css/css-tables/tentative/table-width-redistribution-fixed-padding.html [wpt.fyi]
- table 8:
FAIL - table 11:
FAIL - table 12:
FAIL - table 13:
FAIL - table 15:
FAIL
- table 8:
- /css/css-tables/tentative/table-width-redistribution-fixed.html [wpt.fyi]
- table 13:
FAIL
- table 13:
- /css/css-tables/tentative/table-width-redistribution.html [wpt.fyi]
- table 5:
FAIL
- table 5:
- /css/css-tables/tentative/tbody-height-redistribution.html [wpt.fyi]
- table 7:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - table 8:
FAIL - table 9:
FAIL - table 10:
FAIL - table 11:
FAIL - table 12:
FAIL
- table 7:
- /css/css-tables/tentative/td-box-sizing-003.html [wpt.fyi]
- table 9:
FAIL - table 10:
FAIL
- table 9:
Comment 4•5 days ago
|
||
| bugherder | ||
Comment 5•5 days ago
|
||
| bugherder | ||
Description
•