2089587 - Sponsored story report dialog is missing its heading

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Kyle Kennedy]

Attachment: missing header ad report dialog

When reporting a sponsored story on New Tab, the "Why are you reporting this?" heading above the radio buttons is missing. Reporting a regular story shows the heading as expected.

Build ID: 20261102144711

Prerequisites (about:config):

• browser.search.region set to US
• browser.newtabpage.activity-stream.discoverystream.reportAds.enabled set to true
• browser.newtabpage.activity-stream.discoverystream.sections.enabled set to true

Steps to reproduce (reproduces every time):

1. Open a fresh New Tab. Do not hover over or interact with any regular (non-sponsored) story.
2. Open the context menu on a sponsored story and choose Report.

Expected: the dialog shows "Why are you reporting this?" above the radio buttons.
Actual: there is no heading above the radio buttons.

If you hover over a regular story before step 2, the heading does appear in the sponsored story dialog, which hides the bug.

Cause:
ReportContent.jsx sets data-l10n-id="newtab-report-ads-why-reporting" on the ads moz-radio-group, and that ID is not defined in any .ftl file. Bug 1956388 moved the report strings out of the temporary browser/locales-preview/reportContentTemporary.ftl into newtab.ftl, replacing the separate ads and content headings with a single newtab-report-content-why-reporting-this. The JSX was updated for the content radio group but not the ads one.

Bug 1962115 (filed during QA of 139) reports the sponsored story dialog reopening "without a title" and notes that the content dialog keeps its title. That missing title is most likely this bug; the reopening behavior there is a separate issue.

Notes: the heading appearing after hovering a regular story is probably the reused moz-radio-group keeping the label from an earlier localized render, since Fluent does not clear existing text when an ID is missing.

Likely fix: point the ads moz-radio-group at the existing newtab-report-content-why-reporting-this string, which has the same text, and add a test in ReportContent.test.jsx that checks the ads radio group l10n ID. No new strings are needed.

Comment 1

[BugBot [:suhaib / :marco]]

:rhamoui, since you are the author of the regressor, bug 1956388, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Hackbot [:hackbot]]

Confirmed: the ads moz-radio-group in ReportContent.jsx still uses newtab-report-ads-why-reporting, which no .ftl has defined since bug 1956388 deleted reportContentTemporary.ftl and renamed only the content group at #211. Because <ReportContent> renders once per page and both branches start with an unkeyed moz-radio-group, React reuses the element, so a label Fluent set during an earlier organic render can carry over.

Fix: Point the ads group at the existing newtab-report-content-why-reporting-this from newtab.ftl, so no new strings are needed. Then extend the spoc and organic cases in ReportContent.test.jsx to assert each group's data-l10n-id.

Suggested severity: S3. Every sponsored-story report dialog opened from a fresh New Tab shows radio options with no visible heading and no group label for assistive technology, though reporting itself still works.

---

If you'd like to provide feedback on this comment, please use the 👍 or 👎 reaction.
If you want to categorize your feedback you can add one of the following tags: ai-triage-{wrong-file, wrong-cause, hallucination, out-of-scope, not-a-bug, wrong-fix, shallow-fix, wrong-severity}.

Needinfo [e-mail] to have a patch generated for this bug, include any questions or directions as needed in your comment.

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1956388

Comment 4

[Kyle Kennedy]

Attachment: Bug 2089587 - Use the existing heading string in the New Tab ad report dialog. r?#home-newtab-reviewers-rotation

Bug 1956388 merged the ad and content report headings into
newtab-report-content-why-reporting-this, but the ad radio group still pointed
at the removed newtab-report-ads-why-reporting ID, so it had no heading.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fb3376a2a854
https://hg.mozilla.org/integration/autoland/rev/8391e9de17d1
Use the existing heading string in the New Tab ad report dialog. r=fchasen

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8391e9de17d1

Comment 7

[BugBot [:suhaib / :marco]]

The patch landed in nightly and ESR is affected.

:kkennedy, please make an uplift decision for ESR:

• For ESR, nominate the patch for the appropriate ESR uplift approval if the fix should be included in ESR, or set the ESR status flag(s) to wontfix if an uplift isn't needed. Each affected ESR release needs a decision.

Uplift requests can be submitted from Lando: D342241.

See Requesting an Uplift for documentation on how to request an uplift.

For more information, please visit BugBot documentation.

Comment 8

[Kyle Kennedy]

Bug is cosmetic, not worth uplifting to ESR. Setting ESR 153 to wontfix