2089681 - Let TypedOM run the trains.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2089681 - Let Typed OM ride the trains. r=#style,#layout,janv

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d984003a0d48
https://hg.mozilla.org/integration/autoland/rev/a693d1ab3f55
Let Typed OM ride the trains. r=janv,firefox-style-system-reviewers,layout-reviewers,webidl,dom-worker-reviewers,boris,smaug

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a693d1ab3f55

Comment 4

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: New feature
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: The feature has been enabled on nightly for a very long time, without known regressions.
• String changes made/needed?: none
• Is Android affected?: yes

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2089681 - Let Typed OM ride the trains.

Original Revision: https://phabricator.services.mozilla.com/D340066

Comment 6

[Dianna Smith [:diannaS]]

:emilio did you want to nominate this for release notes as well ?

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Release Note Request (optional, but appreciated)
[Why is this notable]: New feature
[Affects Firefox for Android]: Yes
[Suggested wording]: Firefox now supports the CSS Typed OM Level 1 specification
[Links (documentation, blog post, etc)]: https://drafts.css-houdini.org/css-typed-om/

Comment 8

[Sebastian Zartner [:sebo]]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #7)

[Suggested wording]: Firefox now supports the CSS Typed OM Level 1 specification

This should include the note that CSS color value interfaces are excluded for now, so authors don't get confused when trying to use this feature.

Sebastian

Comment 9

[Performance Sheriff Bot]

Perfherder has detected a browsertime performance change from push a693d1ab3f55ecf2fce9fd9882f86c09ff9c1fff.

No action is required from the author; this comment is provided for informational purposes only.

Improvement	Test	Platform	Options	Absolute values [old vs new]	Performance Profiles
4%	speedometer3 TodoMVC-Svelte-Complex-DOM/total (doc)	android-hw-a55-14-0-aarch64-nightlyasrelease	fission webrender	35.05 ms -> 33.61 ms
3%	speedometer3 TodoMVC-WebComponents/total (doc)	android-hw-a55-14-0-aarch64-nightlyasrelease	fission webrender	50.35 ms -> 48.96 ms

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/d0edd16e0500
https://hg.mozilla.org/releases/mozilla-beta/rev/207ca194e09b

Comment 11

[Pascal Chevrel (relman team) -> :pascalc]

Note added to 161 beta release notes with this updated wording:

Firefox now supports the CSS Typed Object Model, which lets scripts read and write CSS values as typed JavaScript objects instead of strings. Color values, such as CSSColorValue, are not supported yet.