Closed Bug 2089698 Opened 13 days ago Closed 5 days ago

[wpt-sync] Sync PR 64479 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=327945

Categories

(Core :: Layout: Flexbox, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64479 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64479
Details from upstream follow.

Alan Baradlay <zalan@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=327945

WebKit export from bug: [<!---->Flex]<!----> A multi-<!---->line column flex container'<!---->s max-<!---->content width is its widest item,<!----> not the sum of its lines

<pre>
[Flex] A multi-line column flex container's max-content width is its widest item, not the sum of its lines

CSS Flexbox 9.9.2: a multi-line column container's max-content width is the sum of the cross sizes of the flex lines it gets under a cross-axis max-content constraint, plus the gaps.
We used its widest item, as if the items stayed on a single line.

FlexLayout::maximumContentSizeForMultilineColumn now runs flex steps 9.2 to 9.4 #8 with each item at its max-content width and sums the line cross sizes and gaps.
It skips this when the items can't wrap and none is baseline-aligned; percentages resolve against zero, and the cached block sizes stay untouched.
Items laid out this way are marked for layout, and so is the container, since grid and flex parents can ask a laid-out container again.
Grid now lays out dirty baseline-aligned items before each track sizing pass, and css3/flexbox multiline tests expect the summed line widths.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=327945">https://bugs.webkit.org/show_bug.cgi?id=327945</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/324662@main">https://commits.webkit.org/324662@main</a>
</pre>

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 43 tests

Status Summary

Firefox

OK : 4[GitHub] 14[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 1[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, GitHub] 10[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 22[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 7[GitHub] 38[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 54[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 4
PASS: 8

Safari

OK : 4
PASS: 1
FAIL: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 5 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.