[wpt-sync] Sync PR 64479 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=327945
Categories
(Core :: Layout: Flexbox, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 64479 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/64479
Details from upstream follow.
Alan Baradlay <zalan@apple.com> wrote:
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=327945
WebKit export from bug: [<!---->Flex]<!----> A multi-<!---->line column flex container'<!---->s max-<!---->content width is its widest item,<!----> not the sum of its lines
<pre>
[Flex] A multi-line column flex container's max-content width is its widest item, not the sum of its linesCSS Flexbox 9.9.2: a multi-line column container's max-content width is the sum of the cross sizes of the flex lines it gets under a cross-axis max-content constraint, plus the gaps.
We used its widest item, as if the items stayed on a single line.FlexLayout::maximumContentSizeForMultilineColumn now runs flex steps 9.2 to 9.4 #8 with each item at its max-content width and sums the line cross sizes and gaps.
It skips this when the items can't wrap and none is baseline-aligned; percentages resolve against zero, and the cached block sizes stay untouched.
Items laid out this way are marked for layout, and so is the container, since grid and flex parents can ask a laid-out container again.
Grid now lays out dirty baseline-aligned items before each track sizing pass, and css3/flexbox multiline tests expect the summed line widths.WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=327945">https://bugs.webkit.org/show_bug.cgi?id=327945</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/324662@main">https://commits.webkit.org/324662@main</a>
</pre>
| Assignee | ||
Updated•13 days ago
|
| Assignee | ||
Comment 1•9 days ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=117260
| Assignee | ||
Comment 2•8 days ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 43 tests
Status Summary
Firefox
OK : 4[GitHub] 14[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 1[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, GitHub] 10[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 22[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 7[GitHub] 38[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 54[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
Chrome
OK : 4
PASS: 8
Safari
OK : 4
PASS: 1
FAIL: 7
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-flexbox/intrinsic-size/col-wrap-005.html [wpt.fyi]
- body > div 1:
FAIL
- body > div 1:
- /css/css-flexbox/intrinsic-size/col-wrap-019.html [wpt.fyi]
- body > div 1:
FAIL
- body > div 1:
- /css/css-flexbox/intrinsic-size/col-wrap-baseline-001.html [wpt.fyi]
- .flex 1:
FAIL(Chrome:PASS, Safari:FAIL) - .flex 2:
FAIL(Chrome:PASS, Safari:FAIL) - .flex 3:
FAIL(Chrome:PASS, Safari:FAIL) - .flex 4:
FAIL(Chrome:PASS, Safari:FAIL)
- .flex 1:
- /css/css-flexbox/intrinsic-size/col-wrap-calc-size-001.html [wpt.fyi]
- .flex 1:
FAIL(Chrome:PASS, Safari:FAIL) - .flex 2:
FAIL(Chrome:PASS, Safari:FAIL)
- .flex 1:
- /css/css-flexbox/intrinsic-size/col-wrap-percentage-001.html [wpt.fyi]
- .flex 1:
FAIL(Chrome:PASS, Safari:FAIL)
- .flex 1:
- /css/css-flexbox/intrinsic-size/row-005.html [wpt.fyi]
- .floating-flexbox 1:
FAIL - .floating-flexbox 2:
FAIL - .floating-flexbox 3:
FAIL - .floating-flexbox 4:
FAIL - .floating-flexbox 5:
FAIL - .floating-flexbox 6:
FAIL - .floating-flexbox 7:
FAIL - .floating-flexbox 8:
FAIL
- .floating-flexbox 1:
- /css/css-flexbox/intrinsic-size/row-008.html [wpt.fyi]
- .min-width-flexbox 1:
FAIL - .min-width-flexbox 2:
FAIL - .min-width-flexbox 3:
FAIL - .min-width-flexbox 4:
FAIL - .min-width-flexbox 5:
FAIL - .min-width-flexbox 6:
FAIL - .min-width-flexbox 7:
FAIL - .min-width-flexbox 8:
FAIL - .min-width-flexbox 9:
FAIL - .min-width-flexbox 10:
FAIL - .min-width-flexbox 11:
FAIL
- .min-width-flexbox 1:
- /css/css-flexbox/intrinsic-size/row-use-cases-001.html [wpt.fyi]
- left < right:
FAIL - no overflow:
FAIL - same widths:
FAIL - zero width:
FAIL - same heights:
FAIL - no overflow 2:
FAIL
- left < right:
- /css/css-flexbox/intrinsic-size/row-wrap-001.html [wpt.fyi]
- .floating-flexbox 1:
FAIL - .floating-flexbox 2:
FAIL - .floating-flexbox 4:
FAIL - .floating-flexbox 5:
FAIL
- .floating-flexbox 1:
- /css/css-flexbox/intrinsic-size/col-wrap-001.html [wpt.fyi]:
FAIL - /css/css-flexbox/intrinsic-size/col-wrap-002.html [wpt.fyi]:
FAIL - /css/css-flexbox/intrinsic-size/col-wrap-003.html [wpt.fyi]:
FAIL - /css/css-flexbox/intrinsic-size/col-wrap-006.html [wpt.fyi]:
FAIL - /css/css-flexbox/intrinsic-size/col-wrap-007.html [wpt.fyi]:
FAIL - /css/css-flexbox/intrinsic-size/col-wrap-008.html [wpt.fyi]:
FAIL - /css/css-flexbox/intrinsic-size/col-wrap-009.html [wpt.fyi]:
FAIL - /css/css-flexbox/intrinsic-size/col-wrap-013.html [wpt.fyi]:
FAIL - /css/css-flexbox/intrinsic-size/col-wrap-014.html [wpt.fyi]:
FAIL - /css/css-flexbox/intrinsic-size/col-wrap-020.html [wpt.fyi]:
FAIL - /css/css-flexbox/intrinsic-size/col-wrap-dynamic.html [wpt.fyi]:
FAIL - /css/css-flexbox/intrinsic-size/row-002.html [wpt.fyi]:
FAIL - /css/css-flexbox/intrinsic-size/row-003.html [wpt.fyi]:
FAIL - /css/css-flexbox/intrinsic-size/row-004.html [wpt.fyi]:
FAIL - /css/css-flexbox/intrinsic-size/row-007.html [wpt.fyi]:
FAIL - /css/css-flexbox/intrinsic-size/row-wrap-002.tentative.html [wpt.fyi]:
FAIL
Comment 4•5 days ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7c73aa20824b
https://hg.mozilla.org/mozilla-central/rev/3dc005d5846b
Comment 5•5 days ago
|
||
| bugherder | ||
Description
•