Closed Bug 2089712 Opened 16 days ago Closed 8 days ago

[wpt-sync] Sync PR 64478 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=328596

Categories

(Core :: Layout: Block and Inline, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64478 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64478
Details from upstream follow.

Alan Baradlay <zalan@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=328596

WebKit export from bug: [<!---->block-<!---->in-<!---->inline]<!----> Inline-<!---->block with an overflow:<!----> hidden block inside an inline box gets the wrong baseline

<pre>
[block-in-inline] Inline-block with an overflow: hidden block inside an inline box gets the wrong baseline

<div style="display: flex; align-items: center; height: 60px">
<div><div style="display: inline-block; height: 40px">
<span>Details<div style="height: 0; overflow: hidden">Details</div></span>
</div></div>
</div>

The inline-block should be vertically centered in the bar. Instead it was
pushed up past the bar's top edge - its baseline came from the line inside the
clipped block, below the inline-block's bottom edge.

The clipped block sits inside the <span> (block-in-inline), so the baseline
lookup goes through LineLayout::lastLineBaseline, which asked the block for its
own last line. CSS Align says a block container that is a scroll container has
its last baseline at its block-end margin edge.

Apply that rule in the block-in-inline branch of LineLayout::lastLineBaseline,
same as RenderBlock::lastLineBaseline does for block-level children.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=328596">https://bugs.webkit.org/show_bug.cgi?id=328596</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/324661@main">https://commits.webkit.org/324661@main</a>
</pre>

Component: web-platform-tests → Layout: Block and Inline
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 11 tests and 3 subtests

Status Summary

Firefox

OK : 3
PASS: 1[GitHub] 17[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 25[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Status: NEW → RESOLVED
Closed: 8 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.