Open Bug 2089951 Opened 13 days ago

Remove the dead aListener null check in EventListenerManager.cpp

Categories

(Core :: DOM: Events, task)

task

Tracking

()

People

(Reporter: Sylvestre, Unassigned, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=c++])

Filing as a good first bug to learn workflows.

aListener is already dereferenced earlier in this function (aListener->mListener), so testing it for null afterwards is dead code. Drop the aListener && part of the condition below.

Current code:

      // nsWindowRoot to handle KeyPress event.
      if (aListener && aTypeAtom == nsGkAtoms::onkeypress &&
          mTarget->IsRootWindow()) {

Link to the code:
https://searchfox.org/firefox-main/source/dom/events/EventListenerManager.cpp

To verify the fix:

./mach build
./mach test dom/events/test --headless

This was reported by Coverity Scan (CID 1541105). The analyzer will stop reporting it once the change lands.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

You need to log in before you can comment on or make changes to this bug.