Open Bug 2089952 Opened 13 days ago

Return true instead of a pointer in IsClickableContent (PositionedEventTargeting.cpp)

Categories

(Core :: Layout, task)

task

Tracking

()

People

(Reporter: Sylvestre, Unassigned, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=c++])

Filing as a good first bug to learn workflows.

IsClickableContent returns bool, and at this point aContent is known to be non-null, so return aContent; just means return true;. Make that explicit.

Current code:

    }
    return aContent;
  }

Link to the code:
https://searchfox.org/firefox-main/source/layout/base/PositionedEventTargeting.cpp

To verify the fix:

./mach build
./mach test layout/base/tests --headless

This was reported by Coverity Scan (CID 1646524). The analyzer will stop reporting it once the change lands.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

You need to log in before you can comment on or make changes to this bug.