Remove a duplicated didWork check in MessagePump.cpp
Categories
(Core :: IPC, task)
Tracking
()
People
(Reporter: Sylvestre, Unassigned, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=c++])
Filing as a good first bug to learn workflows.
In the message pump loop, a second if (didWork) { continue; } repeats the one just above it, and nothing in between can set didWork (the DoIdleWork result is asserted false and not OR-ed in). Remove the second check.
Current code:
if (didWork) {
continue;
Link to the code:
https://searchfox.org/firefox-main/source/ipc/glue/MessagePump.cpp
To verify the fix:
./mach build
This was reported by Coverity Scan (CID 1361612). The analyzer will stop reporting it once the change lands.
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
Description
•