Remove dead separator checks in nsDisplayList PrintEffects debug dumps
Categories
(Core :: Web Painting, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: mirko, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=c++])
Attachments
(1 external file)
Filing as a good first bug to learn workflows.
In nsDisplayFilters::PrintEffects and nsDisplayMasksAndClipPaths::PrintEffects (debug dumps), first is always true at the first if (!first) test, so that separator branch can never run. Remove the dead check in each function.
Current code:
if (clipPathFrame) {
if (!first) {
aTo += ", ";
Link to the code:
https://searchfox.org/firefox-main/source/layout/painting/nsDisplayList.cpp
To verify the fix:
./mach build
This was reported by Coverity Scan (CIDs 1496226, 1496579). The analyzer will stop reporting it once the change lands.
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
| Assignee | ||
Comment 1•6 days ago
|
||
Updated•6 days ago
|
Description
•