Open Bug 2089968 Opened 14 days ago

Remove two dead stores in nsTableFrame AdjustAndPushBevel

Categories

(Core :: Layout: Tables, task)

task

Tracking

()

People

(Reporter: Sylvestre, Unassigned, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=c++])

Filing as a good first bug to learn workflows.

In AdjustAndPushBevel, bevelRect.max.x += aRect.width() - offset; and bevelRect.max.y += aRect.height() - offset; are dead stores: max.x / max.y are recomputed from min.x / min.y right after. Remove both lines.

Current code:

      bevelRect.min.x += aRect.width() - offset;
      bevelRect.max.x += aRect.width() - offset;
    }

Link to the code:
https://searchfox.org/firefox-main/source/layout/tables/nsTableFrame.cpp

To verify the fix:

./mach build
./mach test layout/tables/test --headless

This was reported by Coverity Scan (CIDs 1496304, 1496623). The analyzer will stop reporting it once the change lands.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

You need to log in before you can comment on or make changes to this bug.