Closed Bug 2090260 Opened 13 days ago Closed 3 days ago

Fill guidance gaps in the desktop-theme skills

Categories

(Developer Infrastructure :: AI for Development, task)

task

Tracking

(firefox162 fixed)

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(7 external files)

Agent runs against the desktop-theme skills' regression fixtures turned up gaps that predate bug 2090203:

  • desktop-theme-tokens uses -moz-windows-mica as its example of a condition with no token key, which gives away one fixture's answer. token-resolve.py doesn't say that it ignores consumer and platform sheets.
  • desktop-theme-colors says to measure contrast with contrast.py, but gives no route without a build or over a backdrop the OS paints (e.g. Windows Mica).
  • desktop-theme-probing says test helpers can't load in a probe, which isn't true once resource://testing-common is mapped. It doesn't say how to find a popup in a screen grab or how to open a second browser window, and it warns about the virtualenv build output only after the first probe has hit it.
  • The recipe for a narrowed selector has no counterpart for a widened one.
  • desktop-theme-screenshots doesn't say that pixel-diff.py exits 1 when pixels differ.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Attachment #9676300 - Attachment description: Bug 2090260 - Generalize desktop-theme-tokens' keyless-condition example and state token-resolve.py's scope. r?#ai4dev-reviewers → Bug 2090260 - Generalize desktop-theme-tokens' keyless-condition example and state `./mach theme tokens`' scope. r?#desktop-theme-reviewers
Attachment #9676301 - Attachment description: Bug 2090260 - Let desktop-theme-colors measure contrast without a build and over an OS-painted backdrop. r?#ai4dev-reviewers → Bug 2090260 - Let desktop-theme-colors measure contrast without a build and over an OS-painted backdrop. r?#desktop-theme-reviewers
Attachment #9676302 - Attachment description: Bug 2090260 - Cover a widened selector beside a narrowed one in the desktop-theme skills. r?#ai4dev-reviewers → Bug 2090260 - Cover a widened selector beside a narrowed one in the desktop-theme skills. r?#desktop-theme-reviewers
Attachment #9676303 - Attachment description: Bug 2090260 - Let desktop-theme-probing load test helpers in a probe, and fill its other setup gaps. r?#ai4dev-reviewers → Bug 2090260 - Let desktop-theme-probing load test helpers in a probe, and fill its other setup gaps. r?#desktop-theme-reviewers,#ai4dev-reviewers
Attachment #9676304 - Attachment description: Bug 2090260 - State pixel-diff.py's exit codes where desktop-theme-screenshots runs it. r?#ai4dev-reviewers → Bug 2090260 - State `./mach theme pixel-diff`'s exit codes where desktop-theme-screenshots runs it. r?#desktop-theme-reviewers
Attachment #9676300 - Attachment description: Bug 2090260 - Generalize desktop-theme-tokens' keyless-condition example and state `./mach theme tokens`' scope. r?#desktop-theme-reviewers → Bug 2090260 - Generalize desktop-theme-tokens' keyless-condition example and state `./mach theme resolve-token`' scope. r?#desktop-theme-reviewers

The watch starts only after the Marionette constructor returns, so it never reads the previous run's log and never times the port wait; it also leaves a started session alone.

Attachment #9676300 - Attachment description: Bug 2090260 - Generalize desktop-theme-tokens' keyless-condition example and state `./mach theme resolve-token`' scope. r?#desktop-theme-reviewers → Bug 2090260 - Generalize desktop-theme-tokens' keyless-condition example and state token_resolve.py's scope. r?#desktop-theme-reviewers
Pushed by dgottwald@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5e4f97cef9a6 https://hg.mozilla.org/integration/autoland/rev/203828fd5326 Generalize desktop-theme-tokens' keyless-condition example and state token_resolve.py's scope. r=desktop-theme-reviewers,tgiles https://github.com/mozilla-firefox/firefox/commit/324c128a7806 https://hg.mozilla.org/integration/autoland/rev/b0a742815152 Cover a widened selector beside a narrowed one in the desktop-theme skills. r=desktop-theme-reviewers,tgiles
Status: ASSIGNED → RESOLVED
Closed: 9 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
Pushed by dgottwald@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5b335b0ed807 https://hg.mozilla.org/integration/autoland/rev/9b8b97ba30a7 Let desktop-theme-colors measure contrast without a build and over an OS-painted backdrop. r=desktop-theme-reviewers,tgiles https://github.com/mozilla-firefox/firefox/commit/12b2fa15605d https://hg.mozilla.org/integration/autoland/rev/d8f3a0a9c72c Let desktop-theme-probing load test helpers in a probe, and fill its other setup gaps. r=desktop-theme-reviewers,tgiles https://github.com/mozilla-firefox/firefox/commit/8faaa1d0404e https://hg.mozilla.org/integration/autoland/rev/14b43e266568 State `./mach theme pixel-diff`'s exit codes where desktop-theme-screenshots runs it. r=desktop-theme-reviewers,tgiles
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Pushed by dgottwald@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ee837bab9d5c https://hg.mozilla.org/integration/autoland/rev/4da163fd0370 Make desktop-theme probes stop a stale build that never starts a Marionette session. r=ai4dev-reviewers,suhaib
Keywords: leave-open
Pushed by dgottwald@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/a7672a7ae52f https://hg.mozilla.org/integration/autoland/rev/9c4ca4e20315 Have desktop-theme-colors check that a changed background keeps its text counterpart. r=desktop-theme-reviewers,tgiles
Status: REOPENED → RESOLVED
Closed: 9 days ago → 3 days ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: