Open Bug 2090312 Opened 12 days ago Updated 7 days ago

[macOS] Remove .moz-draft, .moz-backup and updating leftovers of earlier updates from the app bundle

Categories

(Toolkit :: Application Update, defect)

Unspecified
macOS
defect

Tracking

()

ASSIGNED

People

(Reporter: spohl, Assigned: spohl)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

An update that was interrupted or that failed can leave .moz-draft and .moz-backup files next to the files it replaced, and older updaters can also leave an updating directory at the root of Firefox.app. These files break the bundle's code signature (codesign --verify --deep --strict fails), and nothing removes them on macOS, so the install stays that way until a later update happens to replace the same paths.

Before an update is applied on macOS, the updater should remove these leftovers from the bundle, so that they don't count against the code-signing check of the installation and the bundle's signature is intact again.

See Also: → 2090314

An interrupted or failed update can leave .moz-draft and .moz-backup files in the bundle, and older updaters an updating directory at its root, which break the bundle's code signature. On macOS the updater now removes them before it applies an update. The elevated updater does this through the pinned directory's /.vol path, before it checks the install's signature. Since bug 2076332 the updater only restores the backups that its current run created, so this can't remove one that it still needs.

Attachment #9677614 - Attachment description: Bug 2090312: Remove the leftovers of earlier updates from the macOS app bundle before applying an update. r?#application-update-reviewers,yjuglaret! → Bug 2090312: Undo the leftovers of earlier updates in the macOS app bundle before applying an update. r?#application-update-reviewers,yjuglaret!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: