Closed Bug 2090333 Opened 13 days ago Closed 12 days ago

Padded moz-widget cards have too large of a gap between the header and content

Categories

(Firefox :: Widgets, defect)

defect
Points:
1

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox161 --- fixed
firefox162 --- fixed

People

(Reporter: fchasen, Assigned: fchasen)

References

(Blocks 1 open bug)

Details

(Whiteboard: [hnt][hnt-wattle])

Attachments

(2 external files)

The header and content of a moz-widget with padded are separated by a --space-medium gap but the Crossword widget uses --space-xsmall between the header and content. At the same card height, the content area of every padded moz-widget is too shorter so should switch to the xsmall spacing.

Summary: Padded moz-widget cards have too large of a gap from the header → Padded moz-widget cards have too large of a gap between the header and content

Padded moz-widget cards now leave --space-xsmall between the header and
content, the same spacing as the other New Tab widgets.

Points: --- → 1
Priority: -- → P2
Priority: P2 → --
Type: task → defect
Severity: -- → S3
Status: NEW → RESOLVED
Closed: 12 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: Header spacing will be off for widgets that use moz-widget if that widget is enabled on 161.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing: Will need to enable a widget that uses moz-widget like the "wrexham" one on new tab and compare it's header against the current "crossword" widget.
  • Risk associated with taking this patch: low
  • Explanation of risk level: Small css change, scoped to a single component.
  • String changes made/needed?: N/A
  • Is Android affected?: no
Attachment #9678363 - Flags: approval-mozilla-beta?

Padded moz-widget cards now leave --space-xsmall between the header and
content, the same spacing as the other New Tab widgets.

Original Revision: https://phabricator.services.mozilla.com/D340546

Attachment #9678363 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: