Closed
Bug 2090333
Opened 13 days ago
Closed 12 days ago
Padded moz-widget cards have too large of a gap between the header and content
Categories
(Firefox :: Widgets, defect)
Firefox
Widgets
Tracking
()
RESOLVED
FIXED
162 Branch
People
(Reporter: fchasen, Assigned: fchasen)
References
(Blocks 1 open bug)
Details
(Whiteboard: [hnt][hnt-wattle])
Attachments
(2 external files)
The header and content of a moz-widget with padded are separated by a --space-medium gap but the Crossword widget uses --space-xsmall between the header and content. At the same card height, the content area of every padded moz-widget is too shorter so should switch to the xsmall spacing.
Updated•13 days ago
|
| Assignee | ||
Updated•13 days ago
|
Summary: Padded moz-widget cards have too large of a gap from the header → Padded moz-widget cards have too large of a gap between the header and content
| Assignee | ||
Comment 1•13 days ago
|
||
Padded moz-widget cards now leave --space-xsmall between the header and
content, the same spacing as the other New Tab widgets.
| Assignee | ||
Updated•13 days ago
|
Points: --- → 1
| Assignee | ||
Updated•13 days ago
|
Priority: -- → P2
| Assignee | ||
Updated•13 days ago
|
Priority: P2 → --
| Assignee | ||
Updated•13 days ago
|
Type: task → defect
| Assignee | ||
Updated•13 days ago
|
Severity: -- → S3
Pushed by fchasen@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/da8837339cad
https://hg.mozilla.org/integration/autoland/rev/1066fb20848e
Reduce the gap between the moz-widget header and content. r=mconley
Comment 3•12 days ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 12 days ago
status-firefox162:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
Comment 4•10 days ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined/Reason for urgency: Header spacing will be off for widgets that use
moz-widgetif that widget is enabled on 161. - Code covered by automated testing?: yes
- Fix verified in Nightly?: yes
- Needs manual QE testing?: no
- Steps to reproduce for manual QE testing: Will need to enable a widget that uses
moz-widgetlike the "wrexham" one on new tab and compare it's header against the current "crossword" widget. - Risk associated with taking this patch: low
- Explanation of risk level: Small css change, scoped to a single component.
- String changes made/needed?: N/A
- Is Android affected?: no
Attachment #9678363 -
Flags: approval-mozilla-beta?
| Assignee | ||
Comment 5•10 days ago
|
||
Padded moz-widget cards now leave --space-xsmall between the header and
content, the same spacing as the other New Tab widgets.
Original Revision: https://phabricator.services.mozilla.com/D340546
Updated•10 days ago
|
Attachment #9678363 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•10 days ago
|
status-firefox161:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•