209052 - After Theme switch, Sidebar -Tabs- button disappears after close/open with sidebar visibility tab

Status: RESOLVED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[Tracy Walker [:tracy]]

see on commercial trunk builds:

windows 2003-06-11-04-trunk
linux 2003-06-11-04-trunk
mac 2003-06-11-03-trunk

-create and launch with a new profile
-If in Modern skin, close and open the sidebar. Notice the Tabs button at the
top of the sidebar remains in place, as expected, after sidebar close and open.
-Switch to classic theme and relaunch as needed.
-Close and open the sidebar. Notice the Tabs button has disappeared.  

The only way I've found to get the Tabs button back is to restart the app.  But
once you've used classic skin, the Tabs button will again disappear on
close/open of the sidebar, even if you've switched back to Modern skin.

seems this has been happening for a while...back testing to find regression point.

Comment 1

[Tracy Walker [:tracy]]

this is also on the 1.4 branch

Comment 2

[Tracy Walker [:tracy]]

back tested on linux and narrowed this regression down to sometime between two
builds on april 15.  2003-04-15-08-trunk (works) and 2003-04-15-22-trunk (broken)

Comment 3

[sairuh (rarely reading bugmail)]

nominating --worth fixing for 1.4?

Comment 4

[Samir Gehani]

adt: nsbeta1+/adt2

Comment 5

[shliang]

i'm not able to reproduce this, tried on a couple recent builds.

could you give me more specific steps? 
(i.e. how did you close/open the sidebar, was the sidebar closed or opened 
when the app was closed, did the button disappear on close or on open)

thanks.

Comment 6

[Tracy Walker [:tracy]]

changing summary to better reflect how this happens

-You must switch themes from the default in order to get in a state to see this.
-Restart the app as needed for the theme switch.
-Notice the tabs button is present at the top of the sidebar. If you had the
Sidebar closed, open it.  The Tabs button will be there.
-Close the sidebar using the Close My Sidebar tab in the toolbar or use View |
Show/Hide | My Sidebar.
-Open the sidebar using either method.
-Notice that the Tabs button is gone.
note: using the grippy to close/open doesn't cause this problem.

Upon every restart of the app, the Tabs button will reappear.  But since the
profile in use has gone through a theme change, each time the sidebar is closed
and then reopened, the Tabs button will disappear.

I can't tell if the button is disappearing on close.  Just that when reopened,
it is gone.

Comment 7

[Tracy Walker [:tracy]]

If you switch back to the default theme, the Tabs button will continue to
disappear with a close-open of the sidebar. Once a profile has gone through a
theme switch, it doesn't matter what theme the app is in.  Close-open, with a
method other than using the grippy, will make the button disappear until the
next restart. 

Comment 8

[benc]

UPDATE:
WFM Mozilla 1.6f, Windows XP.

Comment 9

[Tracy Walker [:tracy]]

this is WFM on mozilla trunk

Comment 10

[Alfred Kayser]

Fixed based on 5 years of WORKSFORME