Headless Firefox on Linux never puts tabs in the title bar
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
People
(Reporter: dao, Unassigned, NeedInfo)
References
Details
In --headless on Linux, nsLookAndFeel returns early because there is no GDK display, so it never sets sCSDAvailable. (-moz-gtk-csd-available) and GetDefaultDrawInTitlebar() are then false, and the browser window never gets customtitlebar (CustomTitlebar.systemSupported), even with browser.tabs.inTitlebar=1. Panel animations are off for the same reason.
Windowed runs on GNOME, CI included, get the opposite. A local --headless run therefore lays out the tab strip differently and skips title bar checks, e.g. in browser_970511_undo_restore_default.js, browser_customization_context_menus.js and browser_vertical_tabs.js.
Headless could compute sCSDAvailable from nsWindow::GetSystemGtkWindowDecoration(), which reads only environment variables, and report a stand-in layout for the -moz-gtk-csd-*-button queries. Enabling panel animations headless would change test timing, so that part may want its own check.
Came up in review of D340428.
Updated•7 days ago
|
Comment 1•7 days ago
|
||
Dão, I don't think headless should depend on the desktop it's launched from. GetSystemGtkWindowDecoration() reads XDG_CURRENT_DESKTOP and GTK_CSD, so the same headless test would lay out differently depending on whether it was started from GNOME, i3, or a shell with no desktop at all.
Description
•