Open
Bug 2090683
Opened 12 days ago
Updated 1 day ago
Load the desktop-theme skills for code review of theme changes
Categories
(Developer Infrastructure :: AI for Development, task)
Developer Infrastructure
AI for Development
Tracking
(Not tracked)
ASSIGNED
People
(Reporter: dao, Assigned: dao)
References
(Blocks 2 open bugs)
Details
(Keywords: leave-open)
Attachments
(3 external files)
Add a review-context.toml rule that loads the desktop-theme-colors and desktop-theme-tokens skills when a patch touches browser/themes/, toolkit/themes/ or a *.tokens.json / *.tokens.css file. These skills catch forced-colors, system-color pairing and design token mistakes that reviewers regularly miss.
Both skills assume a running build today: they tell the reader to launch probes and run ./mach theme commands, which an injected reviewer cannot do. Like recomp-frontend-review, they first need an "Injected review" section that lists the checks a reviewer can apply from the diff and turns each live check into a request for the measurement. The layout, probing and screenshots skills stay out, since they need a build throughout.
| Assignee | ||
Comment 1•3 days ago
|
||
Updated•3 days ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
| Assignee | ||
Comment 2•3 days ago
|
||
Updated•3 days ago
|
Attachment #9684950 -
Attachment description: Bug 2090683 - Load the desktop-theme colors and tokens skills when reviewing theme and design-token files. r?#ai4dev-reviewers DONTBUILD → Bug 2090683 - Load the desktop-theme colors, layout and tokens skills when reviewing theme and design-token files. r?#ai4dev-reviewers DONTBUILD
Pushed by dgottwald@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/747aff7889d7
https://hg.mozilla.org/integration/autoland/rev/9f20227d58ef
Prepare the desktop-theme skills for loading into code review. r=ai4dev-reviewers,padenot DONTBUILD
https://github.com/mozilla-firefox/firefox/commit/8b683ce4593f
https://hg.mozilla.org/integration/autoland/rev/e4d997a1b5d2
Load the desktop-theme colors, layout and tokens skills when reviewing theme and design-token files. r=ai4dev-reviewers,padenot DONTBUILD
| Assignee | ||
Updated•1 day ago
|
Keywords: leave-open
| Assignee | ||
Comment 4•1 day ago
|
||
| Assignee | ||
Updated•1 day ago
|
Summary: Load the desktop-theme-colors and desktop-theme-tokens skills for code review of theme changes → Load the desktop-theme skills for code review of theme changes
Comment 5•1 day ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•