Rejected TLS early data is counted under __other__ in network.tls_early_data_accepted
Categories
(Core :: Networking: HTTP, defect, P3)
Tracking
()
People
(Reporter: leggert, Assigned: p.pandey250806, NeedInfo)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=c++][necko-triaged])
Attachments
(1 external file)
TlsHandshaker::EarlyDataTelemetry (netwerk/protocol/http/TlsHandshaker.cpp) records a rejected 0-RTT handshake as:
mozilla::glean::network::tls_early_data_accepted
.Get(earlyDataAccepted ? "accepted"_ns : "not_accepted"_ns)
but network.tls_early_data_accepted in netwerk/protocol/http/metrics.yaml declares only the labels accepted and rejected. Glean maps an undeclared static label to __other__ without recording an error, so rejected has never been recorded since the metric was added in bug 1898018; all rejections land in __other__. (http.tls_early_data_accepted, recorded right above it via EnumGet, is correct.)
Fix: record "rejected"_ns instead of "not_accepted"_ns. No metrics.yaml change is needed.
| Assignee | ||
Comment 1•12 days ago
|
||
Hi Lars, I’d like to take this one.
I’ll have a patch up on Phabricator shortly.
Please assign it to me if that’s fine.
| Reporter | ||
Updated•12 days ago
|
Updated•12 days ago
|
| Assignee | ||
Comment 2•12 days ago
|
||
TlsHandshaker::EarlyDataTelemetry recorded "not_accepted", but
network.tls_early_data_accepted only declares "accepted" and "rejected".
Glean maps undeclared labels to other, so rejections were never
recorded under their own label.
Extend test_happy_eyeballs_0rtt_h1_reject.js to check that a rejected
0-RTT handshake is counted under "rejected".
Comment 3•2 days ago
|
||
There is an r+ patch which didn't land and no activity in this bug for 1 week.
:p.pandey250806, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.
Description
•