2090906 - Firefox closes after pairing from a scanned pairing link when the app was not already open

Status: RESOLVED FIXED

(Firefox for Android :: Accounts and Sync, defect)

Description

[Corentin Bect [:corentin]]

Steps to reproduce

Mobile

1. Install Firefox for Android
2. Complete the onboarding
3. Close Firefox completely
4. Optional steps for debug builds to enable App Links:

• Open system settings
• Click Apps
• Click Default apps
• Click Opening links
• Select Firefox Fenix
• Click Add link
• Enable accounts.firefox.com

Desktop
5. Open Firefox Nightly to access the new pairing QR code
6. Visit https://accounts.firefox.com/pair/authority/scan_qr

Mobile
7. Scan the QR code using your system camera app
8. Complete pairing

Expected: The custom tab closes and Firefox stays open.
Actual: The custom tab closes and the user is brought back to the camera app.

Cause
AuthCustomTabActivity runs in its own task because of android:taskAffinity="" and the activity calls finish() when the authentication succeeds. When Firefox was not already running, there is nothing else in Firefox before AuthCustomTabActivity so Android returns to the previous app.

Comment 1

[twhite]

Attachment: Bug 2090906 - Open HomeActivity after authenticating from a scanned pairing link.

AuthCustomTabActivity runs in its own task, so when a pairing link launches Firefox from another app, finishing it on success returns the user to that app instead of Firefox.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8be9f6660b16
https://hg.mozilla.org/integration/autoland/rev/c84f78cdad49
Open HomeActivity after authenticating from a scanned pairing link. r=android-reviewers,cbect

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/c84f78cdad49