Closed Bug 2090948 Opened 8 days ago Closed 8 days ago

macOS builds failing on arm64 after updating to macOS SDK 27.2

Categories

(Firefox Build System :: Toolchains, defect)

defect

Tracking

(firefox-esr153 unaffected, firefox160 unaffected, firefox161 unaffected, firefox162+ fixed)

RESOLVED FIXED
162 Branch
Tracking Status
firefox-esr153 --- unaffected
firefox160 --- unaffected
firefox161 --- unaffected
firefox162 + fixed

People

(Reporter: abienner, Assigned: RyanVM)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 obsolete files)

Introduced by bug 2072073. D332005 turns off warnings so we can still build with an older macOS SDK version.

However, this is limited to x86_64, but local builds are also using an older SDK, so the workaround from D332005 should be applied to old builds using an older SDK, regarless of the architecture.

Depends on: 2072073

I'll fix this ASAP, sorry for missing it up front.

Assignee: nobody → ryanvm
No longer depends on: 2072073
Keywords: regression
Regressed by: 2072073

A workaround for now:
ac_add_options --enable-macos-target=11.0

Local builds target 10.15 on aarch64 too, so keying the flag on x86_64 missed them.

Attachment #9677883 - Attachment is obsolete: true
Pushed by rvandermeulen@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/67a38d512b90 https://hg.mozilla.org/integration/autoland/rev/b8e4b48dc9ab Disable -Wcpp for every macOS deployment target below 11.0. r=firefox-build-system-reviewers,ArnaudBienner,sergesanspaille
Status: NEW → RESOLVED
Closed: 8 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/02fe1224a9cd https://hg.mozilla.org/mozilla-central/rev/4141e1ca0ba8 Revert "Bug 2090948 - Disable -Wcpp for every macOS deployment target below 11.0. r=firefox-build-system-reviewers,ArnaudBienner,sergesanspaille" for causing conflicts when backing out Bug 2072073 which is causing MACOS nightly balrog issues

Comment on attachment 9677878 [details]
Bug 2090948 - Disable -Wcpp for every macOS deployment target below 11.0. r?#firefox-build-system-reviewers

Revision D340913 was moved to bug 2072073. Setting attachment 9677878 [details] to obsolete.

Attachment #9677878 - Attachment is obsolete: true

Since bug 2072073 was backed out as well, I have moved the patch that was previously attached to this bug over to bug 2072073 to land as one patch stack. Closing this bug as fixed by bug 2072073.

Status: REOPENED → RESOLVED
Closed: 8 days ago → 8 days ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: