Open Bug 2090972 Opened 11 days ago Updated 2 days ago

[customizable menu] Give each browser menu item a stable id

Categories

(Firefox for Android :: Menu, task)

All
Android
task

Tracking

()

ASSIGNED

People

(Reporter: petru, Assigned: petru)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][android-core])

Attachments

(1 external file)

The Tools menu items need to be saved by the user's customization and found again later, so each FenixMenuItem needs an explicit, stable id (e.g. "bookmark", "more").

MenuItemsRegistry should then key its providers by this id, so that "More" still resolves the same provider when it has different sub items (More is a data class holding its children).

No behaviour change.

Rearranging the Tools menu items will persist them, so each item needs an id that
stays the same across releases.

The menu item providers are now found by this id. Before, they were found by
comparing items, but More includes its sub-items in that comparison. Once its
sub-items can be rearranged, a More with different sub-items would no longer be
matched to its provider.

Assignee: nobody → petru
Status: NEW → ASSIGNED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: