Open Bug 2091035 Opened 7 days ago Updated 6 days ago

Move AccessConnectorButton into browser/components/ipprotection

Categories

(Enterprise Products :: Firefox, task)

Tracking

(Not tracked)

People

(Reporter: jporter, Assigned: jporter)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 external file)

Enterprise shows an Access Connector urlbar button and panel, meanwhile IPProtection shows a toolbar button. Right now, the button lives in the our fork at browser/components/enterprise, sharing markup and CSS with the lockdown mode button. It's set up separately from the rest of the IPP code and uses a different implementation.

Its existence in our fork and not upstream results in some changes upstream (e.g. in IPPProxyManager, IPPSiteRuleManager, and getSitePrincipal) that don't immediately get reflected in our implementation, resulting in breakage or feature lag. Moving it next to IPProtectionToolbarButton keeps it in the same component as the code it relies on, so future changes can be updated at the same time.

Moving this now and refactoring to better mirror the IPProtectionToolbarButton implementation will simplify things and make upstreaming of the Access Connector a bit more seamless.

Component: General → Firefox
Blocks: 2091025
No longer depends on: 2091025
Depends on: 2091028
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: