Closed Bug 2091072 Opened 12 days ago Closed 3 days ago

Per-device sync should fail engines instead of going read-only when meta/syncids has a newer format version

Categories

(Firefox :: Sync, task)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: skhamis, Assigned: skhamis)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

When meta/syncids has a version newer than we support, EngineSyncIDs.load uses an empty record in memory and marks it read-only. Engines missing from meta/global then keep syncing with their local sync IDs, which never match what newer clients use, so sync IDs stop detecting wipes for those engines. Nothing reports this, and it lasts until the record is replaced.

Instead, treat a newer format the way we treat a newer engine version: fail the affected engines with VERSION_OUT_OF_DATE until the client is upgraded. Engines listed in meta/global keep syncing as now, and we still never write over the newer record.

Application Services is making the matching change in sync15 (https://github.com/mozilla/application-services/pull/7737).

Assignee: nobody → skhamis
Status: NEW → ASSIGNED
Whiteboard: [fxsync-]
Assignee: skhamis → nobody
Status: ASSIGNED → NEW
Whiteboard: [fxsync-]

Previously a newer-format registry was ignored and treated as read-only, so
engines missing from meta/global kept syncing with local sync IDs that newer
clients never see. We should treat it like a newer engine version instead: those
engines fail with VERSION_OUT_OF_DATE until the client is upgraded.

Assignee: nobody → skhamis
Status: NEW → ASSIGNED
Pushed by skhamis@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ed2ebb66761f https://hg.mozilla.org/integration/autoland/rev/13e1c893e9cd Fail engines that need a meta/syncids record in a newer format. r=markh,sync-reviewers
Status: ASSIGNED → RESOLVED
Closed: 3 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: