Closed Bug 2091239 Opened 9 days ago Closed 5 days ago

[wpt-sync] Sync PR 64481 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=328483

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 64481 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64481
Details from upstream follow.

Alan Baradlay <zalan@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=328483

WebKit export from bug: calc-<!---->size(<!---->auto,<!----> size)<!----> makes an aspect-<!---->ratio box wider than max-<!---->content when a child has a percentage height

<pre>
calc-size(auto, size) makes an aspect-ratio box wider than max-content when a child has a percentage height

RenderBox computed intrinsic widths for calc-size() on an auto width, and for an out-of-flow box's aspect-ratio automatic minimum, without IntrinsicLogicalWidthComputationScope.
So an aspect-ratio box took its height from its stale width, a child's percentage height resolved, and calc-size(auto, size) differed from max-content.

Both paths now set the scope, like the min-content and max-content contribution getters do.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=328483">https://bugs.webkit.org/show_bug.cgi?id=328483</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/324649@main">https://commits.webkit.org/324649@main</a>
</pre>

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Attached file Notable wpt changes —

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 56 tests and 5 subtests

Status Summary

Firefox

OK : 1[GitHub] 33[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 1[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 2[GitHub] 985[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 988[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 989[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 3245[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 3263[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 3264[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 1
PASS: 2

Safari

OK : 1
PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

(See attachment for full changes)

Status: NEW → RESOLVED
Closed: 5 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: