[wpt-sync] Sync PR 64483 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=328593
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 64483 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/64483
Details from upstream follow.
Alan Baradlay <zalan@apple.com> wrote:
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=328593
WebKit export from bug: teams.<!---->microsoft.<!---->com:<!----> `<!---->New Meeting`<!----> &<!----> `<!---->Details`<!----> text is shifted upward while creating new meeting
<pre>
teams.microsoft.com:New Meeting&Detailstext is shifted upward while creating new meeting<div style="display: flex; align-items: center; height: 60px">
<div><button style="height: 40px">Details</button></div>
</div>
button::after { content: "Details"; display: block; height: 0; overflow: hidden }The button should be vertically centered in the bar. Instead it was pushed up
past the bar's top edge - the button's baseline came from the line inside the
clipped ::after, below the button's bottom edge, so the line box (and the
flex item) grew taller than the bar.The button's baseline comes from RenderBlock::lastLineBaseline on its anonymous
inner block, which descended into the overflow: hidden child and took the line
inside it. CSS Align says a block container that is a scroll container has its
last baseline at its block-end margin edge (an inline-block <div> with the same
content already did this through lastInflowBoxBaseline).Apply that rule to scroll container children in RenderBlock::lastLineBaseline.
WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=328593">https://bugs.webkit.org/show_bug.cgi?id=328593</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/324653@main">https://commits.webkit.org/324653@main</a>
</pre>
| Assignee | ||
Updated•9 days ago
|
| Assignee | ||
Comment 1•8 days ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=117692
| Assignee | ||
Comment 2•8 days ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 22 tests and 24 subtests
Status Summary
Firefox
OK : 5
PASS: 1[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, GitHub] 204[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 220[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 13
Chrome
PASS: 1
Safari
FAIL: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /html/rendering/widgets/button-layout/display-other.html [wpt.fyi]
- display: run-in:
FAIL - display: table-row-group:
FAIL - display: table-header-group:
FAIL - display: table-footer-group:
FAIL - display: table-row:
FAIL - display: table-cell:
FAIL - display: table-column-group:
FAIL - display: table-column:
FAIL - display: table-caption:
FAIL - display: ruby-base:
FAIL - display: ruby-text:
FAIL - display: ruby-base-container:
FAIL - display: ruby-text-container:
FAIL
- display: run-in:
Comment 4•5 days ago
|
||
| bugherder | ||
Comment 5•5 days ago
|
||
| bugherder | ||
Description
•