Closed Bug 2091255 Opened 8 days ago Closed 4 days ago

[wpt-sync] Sync PR 64487 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=321091

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox162 fixed)

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64487 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64487
Details from upstream follow.

Alan Baradlay <zalan@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=321091

WebKit export from bug: [<!---->block-<!---->in-<!---->inline]<!----> Margin after a block level box on a line is lost on relayout

<pre>
[block-in-inline] Margin after a block level box on a line is lost on relayout

Laying the block level box out is what produces the margin it hands to the lines after it. A partial layout
that resumes at a later line never re-runs the block, so the rest of the content runs with an empty margin
state and the margin is simply dropped. partialContentTop compounds it: it is derived from the previous
line's lineBoxLogicalRect().maxY(), which excludes the margin.

Bail to a full layout when any line before the damaged one holds a block level box. This is conservative
but the alternative is replaying the margin contribution of every preceding block level line without
laying those blocks out.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=321091">https://bugs.webkit.org/show_bug.cgi?id=321091</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/318660@main">https://commits.webkit.org/318660@main</a>
</pre>

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 817 tests and 2 subtests

Status Summary

Firefox

OK : 2[GitHub] 26[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 2[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, GitHub] 96[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 875[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 877[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 880[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 26[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 31[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 34[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 36[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 2
PASS: 2

Safari

OK : 2
PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.