Closed Bug 2091261 Opened 7 days ago Closed

[wpt-sync] Sync PR 64489 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=319155

Categories

(Core :: Audio/Video: Playback, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64489 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64489
Details from upstream follow.

Ahmad Saleem <ahmad.saleem792+github@gmail.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=319155

WebKit export from bug: [<!---->WebVTT]<!----> A cue wrongly inherits a preceding line as its identifier across a REGION or STYLE block

<pre>
[WebVTT] A cue wrongly inherits a preceding line as its identifier across a REGION or STYLE block

WebVTTParser::collectWebVTTBlock() buffers a candidate cue-identifier line
in m_previousLine while collecting a WebVTT block. When the block then turns
out to be a region or style block, m_previousLine was left untouched, so the
stray line survived across the block and was later applied as the identifier
of the next cue that had no identifier of its own.

Per the "collect a WebVTT block" algorithm [1], a REGION/STYLE block is only
recognized when it is the first line of the block; a line preceding it makes
the whole block a no-op, and the following cue's identifier is the (empty)
buffer. Clear m_previousLine when a region or style block is started so the
buffered line is not carried over.

This matches Firefox on both cases and Chrome on the region case (Chrome has
a separate bug in the style case).

[1] <a href="https://w3c.github.io/webvtt/#collect-a-webvtt-block">https://w3c.github.io/webvtt/#collect-a-webvtt-block</a>

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=319155">https://bugs.webkit.org/show_bug.cgi?id=319155</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/317811@main">https://commits.webkit.org/317811@main</a>
</pre>

Component: web-platform-tests → Audio/Video: Playback
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 42 tests and 1 subtests

Status Summary

Firefox

OK : 2[GitHub] 42[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 2[GitHub] 39[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 3

Chrome

OK : 2
FAIL: 2

Safari

OK : 2
PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 4 days ago
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.