Closed Bug 2091282 Opened 8 days ago Closed 4 days ago

[wpt-sync] Sync PR 64490 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=318918

Categories

(Core :: Layout: Text and Fonts, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64490 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64490
Details from upstream follow.

Alan Baradlay <zalan@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=318918

WebKit export from bug: [<!---->css-<!---->text-<!---->4]<!----> Implement the wrap-<!---->inside property

<pre>
[css-text-4] Implement the wrap-inside property

Add the CSS Text Level 4 'wrap-inside' property (auto | avoid), gated behind the
cssWrapInsideEnabled setting.

'wrap-inside: avoid' suppresses soft wrap opportunities within an inline box: the
line breaks before the box - keeping it together - rather than inside it, and
breaks inside the box only as a last resort when there is no other break
opportunity on the line. A 'wrap-inside: auto' box nested inside an 'avoid' box
does not re-enable breaking, and breaks between sibling avoid boxes are preferred
over breaks inside them.

Whether content is inside an avoid box (the box's own value or inherited from an
ancestor avoid box) is precomputed during style resolution as
effectiveWrapInsideAvoid(), so inline layout reads a flat flag and never walks
the box tree. It propagates only through inline boxes, so it does not cross into
a block, inline-block or other independent formatting context child. The break
decision is made by InlineContentBreaker: when the
overflowing content is inside an avoid box and there is an earlier wrap
opportunity, it asks the line builder to revert to the last wrap opportunity. The
line builder records all wrap opportunities and, on such a revert, prefers the
last one outside any avoid box; when every opportunity is inside an avoid box it
reverts to the outermost such box - a break in an outer box is used before a
break within an inner one - breaking inside the box only as a last resort when it
is the only content on the line.

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=318918">https://bugs.webkit.org/show_bug.cgi?id=318918</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/317182@main">https://commits.webkit.org/317182@main</a>
</pre>

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 24 tests and 6 subtests

Status Summary

Firefox

OK : 1
PASS: 8
FAIL: 6[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 21[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt, GitHub]

Chrome

OK : 1
PASS: 8
FAIL: 21

Safari

OK : 1
PASS: 29

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.