Closed Bug 2091301 Opened 10 days ago Closed 3 days ago

[customizable menu] Hide the notification dot from the menu button if the menu item needing attention was hidden

Categories

(Firefox for Android :: Menu, task)

All
Android
task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: petru, Assigned: giorga)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][android-core])

Attachments

(1 external file)

Steps to reproduce

  1. Hide the menu section showing the "Downloads" menu item
  2. Download something

Expected behavior

The menu button shown in the toolbar does not show a notification dot

Any additional information?

We could use customizedBrowserMenuInfoDataStore.data together with observe the AppState.supportedMenuNotifications to know if the menu item which should be highlighted is shown or not - depending on which the menu button in the toolbar should be highlighted or not.
We need this for both the home and toolbar menu items.

Assignee: nobody → giorga
Pushed by giorga@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/40ab6f7e9a07 https://hg.mozilla.org/integration/autoland/rev/860d6c983868 [customizable menu] Hide the notification dot from the menu button if the menu item needing attention was hidden r=android-reviewers,petru
Status: NEW → RESOLVED
Closed: 3 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: