Closed Bug 2091480 Opened 6 days ago Closed 1 day ago

[wpt-sync] Sync PR 64504 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=319173

Categories

(Core :: Layout: Text and Fonts, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64504 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64504
Details from upstream follow.

Alan Baradlay <zalan@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=319173

WebKit export from bug: [<!---->CSS]<!----> Support the white-<!---->space-<!---->trim:<!----> discard-<!---->inner value

<pre>
[CSS] Support the white-space-trim: discard-inner value

Implement the 'discard-inner' value of the CSS Text 4 'white-space-trim' property
(<a href="https://drafts.csswg.org/css-text-4/#white-space-trim)">https://drafts.csswg.org/css-text-4/#white-space-trim)</a> in the modern inline layout
path, behind the existing CSSWhiteSpaceTrimEnabled setting. This builds on the
'discard-before' / 'discard-after' support.

'discard-inner' removes the collapsible white space at the start and end of the
element's own content -- i.e. immediately inside its edges. It maps onto the same
single forward pass over the inline items that already implements discard-before /
discard-after: a discard-inner inline box start arms the "discard the following
collapsible white space" state (like discard-after does at an end edge), and a
discard-inner inline box end discards the collapsible white space accumulated since
the last piece of real content (like discard-before does at a start edge). Inline
box boundaries remain transparent, so the trimming reaches across nested empty
boxes. As with the other values, only collapsible white space is affected:
preserved white space and non-collapsible characters (e.g. the ideographic space
U+3000) are left untouched.

This covers discard-inner on inline boxes. The block-level facet of the spec --
trimming the collapsible white space at the start and end of each line of a block
container -- is a line-layout-time concern and is left as a follow-up.

This includes the header fix from <a href="https://commits.webkit.org/325401@main.">https://commits.webkit.org/325401@main.</a>

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=319173">https://bugs.webkit.org/show_bug.cgi?id=319173</a>
WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=329730">https://bugs.webkit.org/show_bug.cgi?id=329730</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/317210@main">https://commits.webkit.org/317210@main</a>
</pre>

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 460 tests and 192 subtests

Status Summary

Firefox

OK : 29
PASS: 4[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 403[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 771[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 773[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 1[GitHub] 10[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 67[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 69[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 1 day ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.