Closed Bug 2091508 Opened 5 days ago Closed 11 hours ago

[wpt-sync] Sync PR 64503 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=322718

Categories

(Core :: Layout: Text and Fonts, task, P4)

Product:
Core
Component:
Layout: Text and Fonts
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
162 Branch
Tracking Flags:
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64503 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64503
Details from upstream follow.

Alan Baradlay <zalan@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=322718

WebKit export from bug: [<!---->css-<!---->text-<!---->decor]<!----> Negative text-<!---->decoration-<!---->inset is clipped when the decoration propagates to a descendant inline box

<pre>
[css-text-decor] Negative text-decoration-inset is clipped when the decoration propagates to a descendant inline box

collectInkOverflowForTextDecorations() measured each text box's decoration overflow
from displayBox.layoutBox().parent().style(). The decoration properties are not
inherited, so when a decoration propagates from an ancestor to a descendant inline box
that immediate parent carries the initial values, and the overflow came out too small.
The decoration was still painted in the right place - TextBoxPainter walks up to the
originating box - so it got clipped to the undersized overflow instead.

This includes the lint fix from <a href="https://commits.webkit.org/325400@main.">https://commits.webkit.org/325400@main.</a>

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=322718">https://bugs.webkit.org/show_bug.cgi?id=322718</a>
WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=329720">https://bugs.webkit.org/show_bug.cgi?id=329720</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/320044@main">https://commits.webkit.org/320044@main</a>
</pre>

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 367 tests and 10 subtests

Status Summary

Firefox

OK : 48
PASS: 1[GitHub] 9[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 1374[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 1661[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 1663[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 1664[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 11[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 31[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 32[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 33[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

https://hg.mozilla.org/mozilla-central/rev/810272bcfd21

Status: NEW → RESOLVED
Closed: 11 hours ago
status-firefox162: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.