Closed Bug 2091603 Opened 8 days ago Closed 6 days ago

Upgrade vendored pip to 26.3 by replacing --no-use-pep517 with --no-build-isolation in mozharness

Categories

(Firefox Build System :: General, task, P1)

task

Tracking

(firefox162 fixed)

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: ahochheiden, Assigned: ahochheiden)

References

Details

Attachments

(5 external files)

We pin pip to 25.2 because mozharness passes --no-use-pep517 when it falls back to pip, and pip 25.3 removed that flag. Bug 1868690 added it to avoid the CPU regression from bug 1858663, where pip built each of the ~65 in-tree packages a test task installs in its own isolated build environment.

--no-build-isolation skips that same step and still exists in pip 26.3. Installing marionette_requirements.txt into a fresh venv locally takes 27s with either flag, and 77s with pip 26.3 defaults (68 isolated environments). Since bug 1934096 test tasks run mozharness through uv anyway, the pip fallback only matters for kinds without use-uv, mainly android generate-profile.

pip 26.3 bundles certifi 2026.10.19, so the _update_pip_certifi workaround from bug 2091180 can be safely removed after the upgrade.

pip 25.3 removed --no-use-pep517. Both flags keep pip from building each in
tree package in its own isolated environment, which was the bug 1858663
regression.

pip 26.3 ships a zero width space in a comment in
pip/_internal/utils/unpacking.py, so that file is excluded from the
trojan-source lint.

Re-vendoring without the copy restores the certifi 2026.10.23 that pip 26.3
bundles, which is newer than the separately vendored 2026.10.19.

Nothing has called pip-compile since bug 1659593 moved ./mach vendor python
off it, and pip-tools 7.4.1 no longer imports against pip 26. build and
pyproject-hooks were only pulled in by pip-tools.

Pushed by ahochheiden@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f55623ac2ec0 https://hg.mozilla.org/integration/autoland/rev/4b4bb67b9612 Upgrade certifi to 2026.10.23 r=firefox-build-system-reviewers,perftest-reviewers,mach-reviewers,glandium,aglavic,sergesanspaille,ahal https://github.com/mozilla-firefox/firefox/commit/bee610fdd515 https://hg.mozilla.org/integration/autoland/rev/3b98bef5dfce Pass --no-build-isolation instead of --no-use-pep517 in mozharness r=firefox-build-system-reviewers,sergesanspaille https://github.com/mozilla-firefox/firefox/commit/01ad4cf78341 https://hg.mozilla.org/integration/autoland/rev/791fc20a1516 Upgrade vendored pip to 26.3 r=firefox-build-system-reviewers,mach-reviewers,sergesanspaille,ahal https://github.com/mozilla-firefox/firefox/commit/2d820170df6f https://hg.mozilla.org/integration/autoland/rev/4ddef34b5e94 Stop copying certifi into pip after vendoring r=firefox-build-system-reviewers,mach-reviewers,sergesanspaille,ahal https://github.com/mozilla-firefox/firefox/commit/490094a91851 https://hg.mozilla.org/integration/autoland/rev/06f1e7be6718 Remove the vendored pip-tools r=firefox-build-system-reviewers,mach-reviewers,sergesanspaille,ahal
Pushed by rperta@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ddd8557987e2 https://hg.mozilla.org/integration/autoland/rev/15e3370960f0 Revert "Bug 2091603 - Remove the vendored pip-tools r=firefox-build-system-reviewers,mach-reviewers,sergesanspaille,ahal" for causing failures at role/alert.py

Backed out for causing failures at role/alert.py
Backout link
Push with failures
Failure log(s)

Flags: needinfo?(ahochheiden)

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/65133 for changes under testing/web-platform/tests

(In reply to rperta from comment #8)

Backed out for causing failures at role/alert.py
Backout link
Push with failures
Failure log(s)

Bizarre. I don't think these are related, but I'll confirm on try.

Flags: needinfo?(ahochheiden)
Pushed by ahochheiden@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d5763c6fafa1 https://hg.mozilla.org/integration/autoland/rev/2c018af379cf Upgrade certifi to 2026.10.23 r=firefox-build-system-reviewers,perftest-reviewers,mach-reviewers,glandium,aglavic,sergesanspaille,ahal https://github.com/mozilla-firefox/firefox/commit/519f6a9233b9 https://hg.mozilla.org/integration/autoland/rev/78ba09265b24 Pass --no-build-isolation instead of --no-use-pep517 in mozharness r=firefox-build-system-reviewers,sergesanspaille https://github.com/mozilla-firefox/firefox/commit/911575e983c4 https://hg.mozilla.org/integration/autoland/rev/43068c3f417e Upgrade vendored pip to 26.3 r=firefox-build-system-reviewers,mach-reviewers,sergesanspaille,ahal https://github.com/mozilla-firefox/firefox/commit/70dae84fcd19 https://hg.mozilla.org/integration/autoland/rev/f48657e71dd8 Stop copying certifi into pip after vendoring r=firefox-build-system-reviewers,mach-reviewers,sergesanspaille,ahal https://github.com/mozilla-firefox/firefox/commit/a3816968e4f8 https://hg.mozilla.org/integration/autoland/rev/ad4c502c256c Remove the vendored pip-tools r=firefox-build-system-reviewers,mach-reviewers,sergesanspaille,ahal

Looks like it was a one off!

Upstream PR merged by moz-wptsync-bot

Regressions: 2093335
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: