Upgrade vendored pip to 26.3 by replacing --no-use-pep517 with --no-build-isolation in mozharness
Categories
(Firefox Build System :: General, task, P1)
Tracking
(firefox162 fixed)
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: ahochheiden, Assigned: ahochheiden)
References
Details
Attachments
(5 external files)
We pin pip to 25.2 because mozharness passes --no-use-pep517 when it falls back to pip, and pip 25.3 removed that flag. Bug 1868690 added it to avoid the CPU regression from bug 1858663, where pip built each of the ~65 in-tree packages a test task installs in its own isolated build environment.
--no-build-isolation skips that same step and still exists in pip 26.3. Installing marionette_requirements.txt into a fresh venv locally takes 27s with either flag, and 77s with pip 26.3 defaults (68 isolated environments). Since bug 1934096 test tasks run mozharness through uv anyway, the pip fallback only matters for kinds without use-uv, mainly android generate-profile.
pip 26.3 bundles certifi 2026.10.19, so the _update_pip_certifi workaround from bug 2091180 can be safely removed after the upgrade.
| Assignee | ||
Comment 1•8 days ago
|
||
pip 25.3 removed --no-use-pep517. Both flags keep pip from building each in
tree package in its own isolated environment, which was the bug 1858663
regression.
| Assignee | ||
Comment 2•8 days ago
|
||
pip 26.3 ships a zero width space in a comment in
pip/_internal/utils/unpacking.py, so that file is excluded from the
trojan-source lint.
| Assignee | ||
Comment 3•8 days ago
|
||
Re-vendoring without the copy restores the certifi 2026.10.23 that pip 26.3
bundles, which is newer than the separately vendored 2026.10.19.
| Assignee | ||
Comment 4•8 days ago
|
||
| Assignee | ||
Comment 5•8 days ago
|
||
Nothing has called pip-compile since bug 1659593 moved ./mach vendor python
off it, and pip-tools 7.4.1 no longer imports against pip 26. build and
pyproject-hooks were only pulled in by pip-tools.
Backed out for causing failures at role/alert.py
Backout link
Push with failures
Failure log(s)
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/65133 for changes under testing/web-platform/tests
| Assignee | ||
Comment 10•6 days ago
|
||
(In reply to rperta from comment #8)
Backed out for causing failures at role/alert.py
Backout link
Push with failures
Failure log(s)
Bizarre. I don't think these are related, but I'll confirm on try.
| Assignee | ||
Comment 11•6 days ago
|
||
I can't repro on try:
- no changes: https://treeherder.mozilla.org/jobs?repo=try&revision=3d0aa6ffd95de7f446becee0713fa781c22ffff2
- certifi commit: https://treeherder.mozilla.org/jobs?repo=try&revision=4d3b461cb1c4a8aceedef8e8b56aa7abe18374d8
- pip commit: https://treeherder.mozilla.org/jobs?repo=try&revision=52574104af9de4db56c0ff2a758796446d5d4b86
- full stack: https://treeherder.mozilla.org/jobs?repo=try&revision=ccb6ead94628f22996208cf4ef697eca242faa3c
Let's give landing it another shot...
Comment 12•6 days ago
|
||
| Assignee | ||
Comment 13•6 days ago
|
||
Looks like it was a one off!
Comment 14•6 days ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2c018af379cf
https://hg.mozilla.org/mozilla-central/rev/78ba09265b24
https://hg.mozilla.org/mozilla-central/rev/43068c3f417e
https://hg.mozilla.org/mozilla-central/rev/f48657e71dd8
https://hg.mozilla.org/mozilla-central/rev/ad4c502c256c
Comment 15•6 days ago
|
||
| bugherder | ||
Upstream PR merged by moz-wptsync-bot
Description
•