Closed Bug 2091660 Opened 7 days ago Closed 3 days ago

[wpt-sync] Sync PR 64520 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=311689

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 64520 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64520
Details from upstream follow.

Sammy Gill <sammy.gill@apple.com> wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=311689

WebKit export from bug: REGRESSION(<!---->302241@<!---->main)<!---->:<!----> CSS "<!---->aspect-<!---->ratio"<!----> is not honored when window is zoomed in

<pre>
REGRESSION(<a href="https://commits.webkit.org/302241@main">302241@main</a>): CSS "aspect-ratio" is not honored when window is zoomed in

When we are computing a box's size in an axis (e.g. height) using an
aspect-ratio and its minimum size in that axis (e.g. min-height) is
auto, we need to compute its min-content size as the automatic minimum
size.
<a href="https://drafts.csswg.org/css-sizing-4/#aspect-ratio-minimum">https://drafts.csswg.org/css-sizing-4/#aspect-ratio-minimum</a>

For the logical height, we have this behavior implemented in
RenderBox::constrainLogicalHeightByMinMax.

This includes the reference fix from <a href="https://commits.webkit.org/325407@main.">https://commits.webkit.org/325407@main.</a>

WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=311689">https://bugs.webkit.org/show_bug.cgi?id=311689</a>
WebKit-Bug: <a href="https://bugs.webkit.org/show_bug.cgi?id=329740">https://bugs.webkit.org/show_bug.cgi?id=329740</a>
WebKit-Canonical-Link: <a href="https://commits.webkit.org/310931@main">https://commits.webkit.org/310931@main</a>
</pre>

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 144 tests and 2 subtests

Status Summary

Firefox

OK : 25
PASS: 2[GitHub] 9[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 437[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 513[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 516[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 86[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 117[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 120[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]

Chrome

PASS: 2

Safari

PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 3 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.