Closed Bug 2091664 Opened 4 days ago Closed 3 days ago

Fix fence FD ownership transfer in AndroidImageReader::AcquirePendingImage()

Categories

(Core :: Graphics, defect)

defect

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

AImage_deleteAsync() takes ownership of the fence FD. Passing fence.get() leaves UniqueFileHandle owning the same FD, causing a double close when it goes out of scope. Use fence.release() to transfer ownership and prevent accidentally closing an unrelated FD if the descriptor number is reused.

Assignee: nobody → sotaro.ikeda.g
Blocks: 2080075
Pushed by sikeda.birchill@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/bb349535fc5b https://hg.mozilla.org/integration/autoland/rev/d526d4bb435e Fix fence FD ownership transfer in AndroidImageReader::AcquirePendingImage() r=gfx-reviewers,jnicol
Status: NEW → RESOLVED
Closed: 3 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: