2091710 - [css-values] Implement inherit() behind `layout.css.inherit-function.enabled` pref

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Sajid Anwar [:sajidanwar]]

Implement the inherit() function, introducing the layout.css.inherit-function.enabled pref (and enabling it by default on nightly).

---

Release Note Request
[Why is this notable]: New CSS Feature
[Affects Firefox for Android]: Yes
[Suggested wording]: Firefox Nightly now supports the inherit() arbitrary substitution function, which allows authors to explicitly use the computed value of a custom property from the parent element.
[Links (documentation, blog post, etc)]:

• https://drafts.csswg.org/css-values-5/#inherit-notation (Specification)
• https://groups.google.com/a/mozilla.org/g/dev-platform/c/4T1xf5BPo-0/m/Td08sz3uAQAJ (Intent to Prototype)

Comment 1

[Sajid Anwar [:sajidanwar]]

Attachment: Bug 2091710 - Implement CSS inherit() substitution function. r=#style

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0bbabb574e35
https://hg.mozilla.org/integration/autoland/rev/b8b562da15dc
Implement CSS inherit() substitution function. r=firefox-style-system-reviewers,emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/54e2a3625f67
https://hg.mozilla.org/integration/autoland/rev/193e0c9a192b
Revert "Bug 2091710, Bug 2087544, Bug 2087937 - Implement CSS inherit() substitution function. r=firefox-style-system-reviewers,emilio" for causing wpt failures at custom-property-explicit-inherit-invalidation.html

Comment 4

[rperta]

Backed out for causing wpt failures at custom-property-explicit-inherit-invalidation.html
Backout link
Push with failures
Failure log(s)

Comment 5

[Sajid Anwar [:sajidanwar]]

Missed a test that succeeded with inherit(), pushing an updated patch to resolve this.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c881f64879c8
https://hg.mozilla.org/integration/autoland/rev/86467aa65610
Implement CSS inherit() substitution function. r=firefox-style-system-reviewers,emilio

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/86467aa65610

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/65153 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot