Closed Bug 2091738 Opened 9 days ago Closed 4 days ago

Keep the use-design-tokens rule docs in sync with the properties the rule checks

Categories

(Developer Infrastructure :: Lint and Formatting, task)

task

Tracking

(firefox162 fixed)

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(2 external files)

The use-design-tokens rule page has hand-written sub-pages for nine properties (e.g. color, box-shadow, space), but the rule checks more than those (e.g. fill, stroke, opacity, border-width), and what each sub-page says, such as its allowed non-token values, can drift from tools/lint/stylelint/stylelint-plugin-mozilla/config.mjs.

Either generate a page for every checked property from config.mjs, or drop the sub-pages and list the checked properties on the rule page.

Raised by hjones in review of https://phabricator.services.mozilla.com/D340422.

Blocks: css-linting
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/9836e84a5fbe https://hg.mozilla.org/integration/autoland/rev/120765d088fe Generate the use-design-tokens rule's list of checked properties from config.mjs. r=hjones,desktop-theme-reviewers https://github.com/mozilla-firefox/firefox/commit/298c9b363a59 https://hg.mozilla.org/integration/autoland/rev/93841fd9e950 Stop documenting a per-property option that the use-design-tokens rule doesn't accept. r=hjones
Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/c8101ad5b289 https://hg.mozilla.org/integration/autoland/rev/79cd18836d36 Revert "Bug 2091738 - Stop documenting a per-property option that the use-design-tokens rule doesn't accept. r=hjones" for causing node failures
Pushed by dgottwald@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3855545701c6 https://hg.mozilla.org/integration/autoland/rev/01249a883eca Generate the use-design-tokens rule's list of checked properties from config.mjs. r=hjones,desktop-theme-reviewers https://github.com/mozilla-firefox/firefox/commit/ccb0d7ceefad https://hg.mozilla.org/integration/autoland/rev/cf421117c7c6 Stop documenting a per-property option that the use-design-tokens rule doesn't accept. r=hjones
Flags: needinfo?(dao+bmo)
See Also: → 2093095
Blocks: 2093095
See Also: 2093095 →
Status: ASSIGNED → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: