Open Bug 2091837 Opened 5 days ago Updated 4 days ago

Icons missing in macOS menus after bug 2072073

Categories

(Core :: Widget: Cocoa, defect)

Firefox 162
defect

Tracking

()

ASSIGNED
Tracking Status
firefox-esr153 --- unaffected
firefox160 --- unaffected
firefox161 --- unaffected
firefox162 + affected

People

(Reporter: sam, Assigned: spohl)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 external file)

After bug 2072073, the Bookmarks menu and menus referencing containers are missing their icons in macOS native menus. However, not all native menu icons are missing: Menulists, such as the location dropdown when adding bookmarks, do still have their icons.

Note: I was unable to use mozregression to validate that bug 2072073 is the regressor, due to hg endpoints still returning HTTP 406, but it seems likely based on what I see in local builds.

I'm investigating this and believe I have a fix. The macOS 27.2 SDK header says AppKit now typically hides menu item images unless the application explicitly requests that they stay visible through NSMenuItem.preferredImageVisibility. Firefox currently sets the images without setting that property, so the SDK update looks like the likely explanation.

The change I'm preparing explicitly requests image visibility on macOS 27 and later.

For now, I'm restoring the previous behavior. We can discuss separately whether some of these icons should follow the new macOS default instead.

Assignee: nobody → spohl.mozilla.bugs
Severity: -- → S3
Status: NEW → ASSIGNED
Component: Toolchains → Widget: Cocoa
Product: Firefox Build System → Core

Hi Sam, thank you for reporting this! Could you verify this on your end by running this in Terminal?

(
set -e
mkdir -p "$HOME/Downloads/firefox-try-2091837"
cd "$HOME/Downloads/firefox-try-2091837"
curl --fail --location --output target.tar.gz "https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Wh5KJXPrQqOMk_vAbLxKzw/artifacts/public/build/target.tar.gz"
tar -xzf target.tar.gz
mkdir -p profile appdata cache
cat > bookmarks.html <<'HTML'
<!DOCTYPE NETSCAPE-Bookmark-file-1><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=UTF-8"><TITLE>Bookmarks</TITLE><H1>Bookmarks</H1><DL><p><DT><H3>Menu icon test folder</H3><DL><p><DT><A HREF="https://example.com/" ICON="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAGUlEQVR4nGNgmPD/P0V41IBRA0YNGC4GAAAL0Y4fBU8yswAAAABJRU5ErkJggg==">Menu icon test bookmark</A></DL><p></DL><p>
HTML
printf '%s\n' 'user_pref("browser.aboutwelcome.enabled", false);' 'user_pref("browser.shell.checkDefaultBrowser", false);' 'user_pref("browser.places.importBookmarksHTML", true);' 'user_pref("privacy.userContext.enabled", true);' 'user_pref("privacy.userContext.ui.enabled", true);' > profile/prefs.js
printf 'user_pref("browser.bookmarks.file", "%s");\n' "$PWD/bookmarks.html" >> profile/prefs.js
MOZ_APP_DATA="$PWD/appdata" MOZ_LOCAL_APP_DATA="$PWD/cache" ./Firefox\ Nightly.app/Contents/MacOS/firefox --new-instance -profile "$PWD/profile"
)

In the try build, open "Bookmarks" > "Menu icon test folder" and "File" > "New Container Tab". Could you confirm whether the folder, bookmark, and container icons are visible?

After quitting the try build, you can delete ~/Downloads/firefox-try-2091837 to remove the test files. Thank you!

Flags: needinfo?(sam)

Hi Stephen! The try build works great, I see the icons as expected. Thanks!

Flags: needinfo?(sam)

The bug is marked as tracked for firefox162 (nightly). However, the bug still has low severity.

:jstutte, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Flags: needinfo?(jstutte)
Duplicate of this bug: 2091915
Severity: S3 → S2
Flags: needinfo?(jstutte)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: