Closed Bug 2091876 Opened 3 days ago Closed 11 hours ago

[wpt-sync] Sync PR 64529 - Throw SyntaxError for unparsable matchContainer() queries

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 64529 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64529
Details from upstream follow.

Seokho Song <seokho@chromium.org> wrote:

Throw SyntaxError for unparsable matchContainer() queries

Spec requires matchContainer() to throw a SyntaxError when
the container query list fails to parse [1]. Previously it returned a
list that never matched.

Unknown features such as "(invalid-feature)" still parse and evaluate to
false.

[1] https://drafts.csswg.org/css-conditional-5/#the-matchContainer-method

Bug: 40887402
Change-Id: If647cdc5c5970d15e4deecd287a5c095fc38c2f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8439896
Commit-Queue: Seokho Song \<seokho@chromium.org>
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1732635}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Attached file Notable wpt changes —

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 471 tests

Status Summary

Firefox

OK : 1[GitHub] 44[Gecko-windows11-32-25h2-opt] 234[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 63[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 1905[Gecko-windows11-32-25h2-opt] 3029[Gecko-windows11-32-25h2-debug] 3185[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 3189[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 3200[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
FAIL: 29[GitHub] 69[Gecko-windows11-32-25h2-opt] 297[Gecko-windows11-32-25h2-debug] 299[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 310[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 314[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 1
FAIL: 29

Safari

OK : 1
FAIL: 29

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

(See attachment for full changes)

Status: NEW → RESOLVED
Closed: 11 hours ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: