Closed Bug 2091878 Opened 8 days ago Closed 4 days ago

[wpt-sync] Sync PR 64530 - Propagate NaN through min(), max() and clamp() in deferred calc

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox162 fixed)

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 64530 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/64530
Details from upstream follow.

Aakash <aaka3h@gmail.com> wrote:

Propagate NaN through min(), max() and clamp() in deferred calc

The deferred calc evaluator computed min()/max() with
std::min()/std::max() and clamp() with a std::max(std::min())
combination. Those drop a NaN second argument, so a NaN operand that
followed a percentage (resolved in this later path) was silently
discarded: width: min(12.5%, NaN * 1px) computed to 12.5% of the
container instead of 0, and the result depended on argument order.

Per CSS Values 4, any operation with a NaN argument produces NaN, and
a top-level NaN calculation resolves to zero. Propagate NaN explicitly
in the three operators so they match the non-deferred evaluator.

Extend the computed-value WPT with percentage-based min/max/clamp NaN
cases.

Bug: 579214227
Change-Id: I52a871a9d0479c9447ace5a3b9d9f466a0b5a470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8684761
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Commit-Queue: Rune Lillesveen \<futhark@chromium.org>
Reviewed-by: Helmut Januschka \<helmut@januschka.com>
Cr-Commit-Position: refs/heads/main@{#1732677}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Attached file Notable wpt changes —

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 522 tests

Status Summary

Firefox

OK : 1[GitHub] 285[Gecko-linux2404-64-debug] 286[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 22[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 70[GitHub] 6313[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 6466[Gecko-linux2404-64-debug, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 6467[Gecko-linux2404-64-opt] 6479[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
FAIL : 3[GitHub] 4103[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 4149[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 4163[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 4164[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
TIMEOUT: 1

Chrome

OK : 1
PASS : 68
FAIL : 5

Safari

OK : 1
PASS : 73

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

(See attachment for full changes)

Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: